Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce number of aiohttp.TCPConnector cleanup_closed checks to one per minute #123268

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Aug 7, 2024

Proposed change

The default of 2.0 seconds is too low for our use case as most tls/ssl connections will close cleanly, and cleanup_closed is only needed for connections that fail to correctly abort. Cleaning these up every 60.0 seconds is more than sufficient as every 2.0 seconds generated an excessive amount of event loop scheduling.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

…r minute

The default of 2.0 seconds is too low for our use case as most
tls/ssl connections will close cleanly, and cleanup_closed is
only needed for connections that fail to correctly abort. Cleaning
these up every 60.0 seconds is more than sufficient as every 2.0
seconds generated an excessive amount of event loop scheduling.
@home-assistant home-assistant bot added cla-signed code-quality core small-pr PRs with less than 30 lines. labels Aug 7, 2024
@bdraco
Copy link
Member Author

bdraco commented Aug 7, 2024

I probably need to fix some more upstream first since it churns the timer handles just like we see in aio-libs/aiohttp#8608

@bdraco
Copy link
Member Author

bdraco commented Aug 8, 2024

This is working exactly as expected. The problem I was seeing is from other connector instances not using our helper which have the default value which creates a timer every 2s

@bdraco bdraco marked this pull request as ready for review August 8, 2024 20:52
@bdraco bdraco requested a review from a team as a code owner August 8, 2024 20:52
@bdraco bdraco merged commit 69740e8 into dev Aug 8, 2024
40 checks passed
@bdraco bdraco deleted the cleanup_closed branch August 8, 2024 20:52
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants