-
-
Notifications
You must be signed in to change notification settings - Fork 32.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mypy-dev to 1.12.0a1 #121428
Update mypy-dev to 1.12.0a1 #121428
Conversation
Hey there @emontnemery, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
What's |
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
https://mypy.readthedocs.io/en/latest/typed_dict.html#inline-typeddict-types -class _FloorStoreData(TypedDict):
- aliases: list[str]
- floor_id: str
- icon: str | None
- level: int | None
- name: str
-
-
class FloorRegistryStoreData(TypedDict):
- floors: list[_FloorStoreData]
+ floors: list[
+ {
+ "aliases": list[str],
+ "floor_id": str,
+ "icon": str | None,
+ "level": int | None,
+ "name": str,
+ }
+ ]
Yeah, it's unfortunate that it got removed from pyright. Tbh the setting would have been more useful for general experimentation than anything else. Mostly because the mypy cache gets invalidated if the global settings change. I removed it. Let's hope the PEP gets of the ground eventually. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @cdce8p 👍
../Frenck
Proposed change
https://github.com/cdce8p/mypy-dev/releases/tag/1.12.0a1
Compare: python/mypy@39b9b89...6d45f3c
New features:
New issues were already fixed in Typing improvements #120297
Not sure this is useful for us at this point as it isn't defined in a PEP yet. Anyway, it will allow us to experiment with it. Maybe we find a good use case for it.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: