Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mypy-dev to 1.12.0a1 #121428

Merged
merged 4 commits into from
Jul 7, 2024
Merged

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Jul 7, 2024

Proposed change

https://github.com/cdce8p/mypy-dev/releases/tag/1.12.0a1
Compare: python/mypy@39b9b89...6d45f3c

New features:

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Jul 7, 2024

Hey there @emontnemery, mind taking a look at this pull request as it has been labeled with an integration (tasmota) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tasmota can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign tasmota Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@joostlek
Copy link
Member

joostlek commented Jul 7, 2024

What's InlineTypedDict?

@home-assistant home-assistant bot marked this pull request as draft July 7, 2024 12:56
@home-assistant
Copy link

home-assistant bot commented Jul 7, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@cdce8p
Copy link
Member Author

cdce8p commented Jul 7, 2024

What's InlineTypedDict?

https://mypy.readthedocs.io/en/latest/typed_dict.html#inline-typeddict-types
Probably the most useful case for us would have been nested TypedDicts like in the registry helpers.

-class _FloorStoreData(TypedDict):
-    aliases: list[str]
-    floor_id: str
-    icon: str | None
-    level: int | None
-    name: str
-
-
 class FloorRegistryStoreData(TypedDict):
-    floors: list[_FloorStoreData]
+    floors: list[
+        {
+            "aliases": list[str],
+            "floor_id": str,
+            "icon": str | None,
+            "level": int | None,
+            "name": str,
+        }
+    ]

I don't think we show enable this, mostly because of the release notes @ pyright

Yeah, it's unfortunate that it got removed from pyright. Tbh the setting would have been more useful for general experimentation than anything else. Mostly because the mypy cache gets invalidated if the global settings change. I removed it. Let's hope the PEP gets of the ground eventually.

@cdce8p cdce8p marked this pull request as ready for review July 7, 2024 13:34
@home-assistant home-assistant bot requested a review from frenck July 7, 2024 13:34
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @cdce8p 👍

../Frenck

@frenck frenck merged commit 37ffe09 into home-assistant:dev Jul 7, 2024
40 checks passed
@cdce8p cdce8p deleted the update-mypy-1.12.0a1 branch July 7, 2024 14:11
@github-actions github-actions bot locked and limited conversation to collaborators Jul 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed dependency small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants