Re-enable dns-mijn-host

[mijnhost]

This is now fixed in mijnhost/certbot-dns-mijn-host#6

Summary by CodeRabbit

• New Features
  • Activated support for the mijn-host DNS provider, giving users an additional DNS challenge option.
• Documentation
  • Updated details to reflect that the mijn-host DNS provider is now enabled and available for use.
• Chores
  • Reactivated installation of the certbot-dns-mijn-host package.
  • Updated the version of the CERTBOT_DNS_MIJN_HOST_VERSION argument to 0.0.8.
  • Updated the version number in the configuration file to 5.3.3 and noted breaking changes.

[home-assistant]

Hello @mijnhost,

When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).

The commits that are missing a linked GitHub account are the following:

• 0952767102fc90652aa389bd945161251539e859 - This commit has something that looks like an email address (marijn@mijn.host). Maybe try linking that to GitHub?.

Unfortunately, we are unable to accept this pull request until this situation is corrected.

Here are your options:

1. If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.

2. If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.

   • If you only made a single commit you should be able to run

     git commit --amend --author="Author Name <email@address.com>"
     

     (substituting "Author Name" and "email@address.com" for your actual information) to set the authorship information.
   • If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
     1. You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
     2. You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
   • Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.

Thanks, I look forward to checking this PR again soon! ❤️

[home-assistant]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

[agners]

Hm, this seems to miss an actual release of certbot-dns-mijn-host on PyPI, and the bump to that version here no?

Also, make sure to address the commit issue raised by the home-assistant bot.

[mijnhost]

@agners I've now added the correct e-mail address. Also a new version is now released in PyPi.

[home-assistant]

Hi @mijnhost

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

Stale

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request updates the Letsencrypt add-on by modifying its documentation, Dockerfile, build configuration, changelog, and configuration file. The documentation now reflects that the "mijn-host" DNS provider is enabled by removing the previously noted disabled status. The Dockerfile has been updated to reinstate the installation of the certbot-dns-mijn-host package, which was previously commented out due to unresolved issues. The version of the CERTBOT_DNS_MIJN_HOST_VERSION argument has been incremented, the changelog has been updated to reflect the re-enabling of the plugin, and the configuration file version has been updated as well. There are no changes to the underlying logic, error handling, or control flow.

Changes

File(s)	Change Summary
letsencrypt/DOCS.md	Removed the phrase "(currently disable - see changelog)" from the DNS provider "mijn-host" entries to indicate it is now enabled.
letsencrypt/Dockerfile	Uncommented the installation line for certbot-dns-mijn-host, allowing the package to be installed, while the certbot-dns-websupport remains disabled.
letsencrypt/build.yaml	Updated the CERTBOT_DNS_MIJN_HOST_VERSION from 0.0.5 to 0.0.8.
letsencrypt/CHANGELOG.md	Added new version entry ## 5.3.3 and noted the change Re-enabled certbot-dns-mijn-host.
letsencrypt/config.yaml	Updated version from 5.3.2 to 5.3.3 and modified breaking_versions to include 5.3.0.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between faf9f4e and a9f2028.

📒 Files selected for processing (1)

• letsencrypt/build.yaml (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• letsencrypt/build.yaml

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[agners]

@mijnhost from what I can tell the bump of CERTBOT_DNS_MIJN_HOST_VERSION in build.yaml is still missing.

[mijnhost]

@agners this is now also done.

[agners]

Ok thanks! I think tests should run through cleanly now.

However, I forgot to mention: This PR still needs a bump in config.yaml to 5.3.3 and an entry in CHANGELOG.md.

[agners]

LGTM, thanks!

[agners]

@mijnhost actually, it seems there is still a dependency conflict:

48.22 The conflict is caused by:
48.22     certbot-dns-mijn-host 0.0.6 depends on pyOpenSSL==24.2.1
48.22     acme 3.2.0 depends on PyOpenSSL>=25.0.0

[shubhamku044]

hii @agners , I have fixed the version issue in mijn-host, can you please approve it again
Thanks!!

[agners]

@mijnhost still the same it seems?

 43.96 The conflict is caused by:
43.96     certbot-dns-mijn-host 0.0.7 depends on pyOpenSSL==24.2.1
43.96     acme 3.2.0 depends on PyOpenSSL>=25.0.0

[agners]

LGTM, thanks!