-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openthread_border_router: Add support for network RCP radio #3532
Conversation
Hm, interesting. I guess this quickly calls for multiple OTBR instances 🙈 It seems those have ESP32 on it, have you considered running a BR on the ESP32 instead (https://github.com/espressif/esp-thread-br/)? |
Yes I guess it sort of lends itself to that, lets start with just one though ;P
Yes they are based on ESP32 with either EFR32MG21 or CC2652P SoCs , it should be possible to run the espressif BR on them. However the existing ESP32 firmware on these that provides the web UI etc is Arduino based, whereas the Thread stuff is all ESP-IDF, so would likely have to loose the web UI. I will likely look into this further later on, but for now is outside of the scope of my current projects. |
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Baudrate fixes for SMLIGHT side are now availabe in the SLZB firmware |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good.
Has this been tested in practice? I wonder how time sensitive the RCP protocol is, and if tunneling it through WiFi works reliably in practice.
openthread_border_router/rootfs/etc/s6-overlay/s6-rc.d/socat-otbr-tcp/run
Outdated
Show resolved
Hide resolved
Co-authored-by: Stefan Agner <stefan@agner.ch>
It has been tested over ethernet on the smlight adapters at 460800 baud, and seems to work well. I not sure about Wifi, I havent tested this (and wifi is not particularly good on smlight adapters), but given the history of issues with wifi zigbee bridges, it may have issues there particularly with the slow esp32 wifi. Perhaps there could be a recommendation to only use with ethernet bridges, of which there are quite a few options on the market these days. |
So checking back with OpenThread folks they told me that the RCP protocol is rather timing sensitive. Apparently the NCP model is less timing sensitive, but supposedly NCP isn't fully supported yet with the latest Thread version. As you might have noticed, I am a bit hesitant merging this as it adds complexity and potential issues. Maybe it could be maintained/deployed in a fork of this add-on for now for testing 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing I just noticed: The new option network_device is missing in the translation yaml.
It seems to handle a direct ethernet link (same LAN) fine, but can imagine there could be problems over Wifi etc.
I suppose could try and get some more widespread testing, especially on other devices such as the Tube's gateways etc which I dont have access to myself.
Fixed this, I am sure I had done that previously but may have been lost in rebase somewhere |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, found another small issue.
The implementation is quite clean, and if we'll support NCP radios it will require something very similar (just with a slightly different URL). So adding it for RCP with the caveat you've added seems reasonable.
Co-authored-by: Stefan Agner <stefan@agner.ch>
sorry for being dumb, (and technically asking in the wrong place), does this change mean if I run the OTBR add-on on my home assistant it can connect to a dongle (say the sky connect) plugging into a raspberrypi that is else where? (currently I have the upstream otbr docker container on the pi) |
Your probably better off sticking with the OTBR running on the pi, however in theory you could setup |
Thanks, i finally got the official OTBR running on the pi. Only issue is if the container goes down the otbr integration doesn't reform the network on the remote pi when the container comes backup. Workaround remove the otbr integration and readd it - then the network forms. https://github.com/orgs/openthread/discussions/10311#discussioncomment-9744253 i assume this is not an issue with the addon-otbr container on as things can be orchestrated by the supervisor? --edit-- |
I am working on supporting Openthread on the SMLIGHT SLZB-06 range of network ethernet coordinators. This support will include both Silabs and TI variants.
Add support for network sockets using socat, similar to what is done in Silabs-Multiprotocol addon. Thus allowing the ethernet coordinators to be used with Openthread addon.
This has worked well in testing, however it currently requires an as yet unreleased firmware update fixing baudrates > 115200 on the SLZB-06x. This will be released soon however.
darkxst