Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

letsencrypt: Add support for ClouDNS provider #3401

Merged

Conversation

tedski
Copy link
Contributor

@tedski tedski commented Jan 8, 2024

Adds support for ClouDNS provider for Let's Encrypt SSL certificates. Uses the certbot-dns-cloudns plugin.

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tedski

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant bot marked this pull request as draft January 8, 2024 16:41
@home-assistant
Copy link

home-assistant bot commented Jan 8, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@tedski tedski marked this pull request as ready for review January 8, 2024 16:46
@agners
Copy link
Member

agners commented Jan 8, 2024

It seems there is a minor linter error which needs addressing.

probably also make sense to add documentation for this provider, along with the two authentication options (auth_id/sub_auth_id).

@agners
Copy link
Member

agners commented Jan 8, 2024

Fixes: #1022

@tedski
Copy link
Contributor Author

tedski commented Jan 8, 2024

I see the pip dependency issue and will work on that today.

@tedski
Copy link
Contributor Author

tedski commented Jan 8, 2024

It seems there is a minor linter error which needs addressing.

probably also make sense to add documentation for this provider, along with the two authentication options (auth_id/sub_auth_id).

Oops! I missed the Example configs section. Will update that.

@tedski tedski marked this pull request as draft January 8, 2024 18:17
@tedski
Copy link
Contributor Author

tedski commented Jan 8, 2024

Waiting on dep bump in inventage/certbot-dns-cloudns#4

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @tedski,

When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).

The commits that are missing a linked GitHub account are the following:

Unfortunately, we are unable to accept this pull request until this situation is corrected.

Here are your options:

  1. If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.

  2. If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.

    • If you only made a single commit you should be able to run
      git commit --amend --author="Author Name <email@address.com>"
      
      (substituting "Author Name" and "email@address.com" for your actual information) to set the authorship information.
    • If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
      1. You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
      2. You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
    • Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.

Thanks, I look forward to checking this PR again soon! ❤️

@tedski tedski force-pushed the tedski/feat/letsencrypt-cloudns-provider branch from 7b105c7 to 74b5ed6 Compare January 8, 2024 18:26
@agners agners force-pushed the tedski/feat/letsencrypt-cloudns-provider branch from 74b5ed6 to 9bb2cbf Compare January 8, 2024 18:52
@tedski tedski force-pushed the tedski/feat/letsencrypt-cloudns-provider branch from fe3f16d to bda6ecc Compare January 8, 2024 21:24
Adds support for ClouDNS provider for Let's Encrypt SSL certificates.
Uses the certbot-dns-cloudns plugin.
@tedski tedski force-pushed the tedski/feat/letsencrypt-cloudns-provider branch from bda6ecc to c3b3ff3 Compare January 16, 2024 15:28
@tedski tedski marked this pull request as ready for review January 16, 2024 15:29
@tedski
Copy link
Contributor Author

tedski commented Jan 16, 2024

Waiting on dep bump in inventage/certbot-dns-cloudns#4

Dependency was updated to support newer acme versions. We should be good to go now.

@tedski
Copy link
Contributor Author

tedski commented Jan 17, 2024

I seem to have added the bot as a reviewer accidentally. I'm not sure if this will block the merge process from any automation, but I don't seem to be able to remove the bot from the reviewers list. Let me know if there's anything else I need to complete to get this merged.

@agners
Copy link
Member

agners commented Jan 17, 2024

All good, sorry I missed merging this.

@agners agners merged commit 788ae56 into home-assistant:master Jan 17, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants