Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nginx_proxy: Support longer domains name #3399

Merged
merged 3 commits into from
Jan 8, 2024
Merged

nginx_proxy: Support longer domains name #3399

merged 3 commits into from
Jan 8, 2024

Conversation

samuelef95
Copy link
Contributor

Add support for longer domain name, modifying server_names_hash_bucket_size from 64 to 128

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @samuelef95

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

home-assistant bot commented Jan 7, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft January 7, 2024 20:57
@samuelef95 samuelef95 marked this pull request as ready for review January 7, 2024 20:59
@agners agners changed the title Support longer domains name nginx_proxy: Support longer domains name Jan 8, 2024
@agners
Copy link
Member

agners commented Jan 8, 2024

In what case is this problematic? I guess if you use a long domain name, but what is the outcome in that case?

@samuelef95
Copy link
Contributor Author

Yes, exactly when i use a long domain name.

The error I find in the log Is:

INFO: Running nginx...
nginx: [emerg] could not build server_names_hash, you should increase server_names_hash_bucket_size: 64
[19:27:51] INFO: Service nginx exited with code 1 (by signal 0)
s6-rc: info: service legacy-services: stopping
s6-rc: info: service legacy-services successfully stopped
s6-rc: info: service crond: stopping
[19:27:51] INFO: Service crond exited with code 256 (by signal 15)

I didn't find a way to increase the value using custom nginx configuration because it's already defined in "http" method and can be defined only only there.

As a temporary solution I'm using *.duckdns.org.

@agners agners merged commit 6e118fa into home-assistant:master Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants