Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nginx_proxy: Update documentation #3373

Merged
merged 1 commit into from
Dec 30, 2023

Conversation

tkurki
Copy link
Contributor

@tkurki tkurki commented Dec 26, 2023

  • Make the difference between global configuration and add-on configuration clear.
  • Include reference to 400 bad request (symptom of missing configuration)
  • Add reference to Let's Encrypt.
  • Demote the note about no longer relevant configuration options.

See also #3289.

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tkurki

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant bot marked this pull request as draft December 26, 2023 10:08
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@agners agners changed the title update nginx doc nginx: Update documentation Dec 27, 2023
@agners agners changed the title nginx: Update documentation nginx_proxy: Update documentation Dec 27, 2023
- Make the difference between global configuration and add-on configuration clear.
- Include reference to 400 bad request (symptom of missing configuration)
- Add reference to Let's Encrypt.
- Demote the note about no longer relevant configuration options.
@tkurki
Copy link
Contributor Author

tkurki commented Dec 29, 2023

  • added Troubleshooting section and moved 400 response comment there
  • squashed and force pushed

@agners agners merged commit e6031ff into home-assistant:master Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants