Ensure View.kwargs are validated #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
commented
Nov 1, 2023
Codecov Report
@@ Coverage Diff @@
## main #498 +/- ##
==========================================
+ Coverage 69.38% 69.40% +0.02%
==========================================
Files 79 79
Lines 9171 9185 +14
==========================================
+ Hits 6363 6375 +12
- Misses 2808 2810 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
hoxbro
approved these changes
Nov 1, 2023
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt at making sure that we validate when we can but also allow passing custom kwargs to
Viewtypes. AViewthat declares a_panel_typeand passes the kwargs directly to the underlying Panel object can easily be fully validated.