Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically create Variables classes to avoid shared state #413

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

philippjfr
Copy link
Member

Sharing a single class for all Variables instances caused issues because when dynamically adding parameters to an instance this would mess with other instances. Therefore we now dynamically create new Variables classes for each instance.

@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2022

Codecov Report

Merging #413 (bbe3efe) into main (eaef7bf) will decrease coverage by 0.19%.
The diff coverage is 84.74%.

@@            Coverage Diff             @@
##             main     #413      +/-   ##
==========================================
- Coverage   68.51%   68.32%   -0.20%     
==========================================
  Files          73       73              
  Lines        8251     8419     +168     
==========================================
+ Hits         5653     5752      +99     
- Misses       2598     2667      +69     
Impacted Files Coverage Δ
lumen/validation.py 87.50% <ø> (ø)
lumen/rest.py 24.34% <50.00%> (ø)
lumen/sources/intake_dremio.py 57.14% <50.00%> (ø)
lumen/ui/fast.py 73.33% <50.00%> (-3.53%) ⬇️
lumen/schema.py 57.41% <66.66%> (-0.20%) ⬇️
lumen/sources/base.py 63.20% <72.22%> (-0.04%) ⬇️
lumen/ui/state.py 70.83% <75.00%> (-4.78%) ⬇️
lumen/ui/views.py 41.08% <75.00%> (+0.58%) ⬆️
lumen/state.py 64.61% <77.04%> (-1.92%) ⬇️
lumen/dashboard.py 76.51% <81.57%> (-1.13%) ⬇️
... and 45 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit fac5b72 into main Dec 15, 2022
@philippjfr philippjfr deleted the variable_cls branch December 15, 2022 18:31
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants