Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create core concepts and update tutorial in getting started guide #336

Merged
merged 13 commits into from
Sep 29, 2022
Merged

create core concepts and update tutorial in getting started guide #336

merged 13 commits into from
Sep 29, 2022

Conversation

droumis
Copy link
Member

@droumis droumis commented Sep 27, 2022 •
edited
Loading

127 0 0 1_5500_docs__build_html_getting_started_installation html (1)

127 0 0 1_5500_docs__build_html_getting_started_build_dashboard html (2)

127 0 0 1_5500_docs__build_html_getting_started_core_concepts html (2)

@hoxbro
Copy link
Member

hoxbro commented Sep 28, 2022

Pipeline.ipynb has been added by a mistake. It is copied to the folder when running sphinx-build and should not be part of the repo.

@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2022 •
edited
Loading

Codecov Report

Merging #336 (e6b35a2) into master (8a65529) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #336   +/-   ##
=======================================
  Coverage   67.22%   67.22%           
=======================================
  Files          71       71           
  Lines        7340     7340           
=======================================
  Hits         4934     4934           
  Misses       2406     2406

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@droumis droumis marked this pull request as ready for review September 28, 2022 14:55
@philippjfr
Copy link
Member

This looks fabulous, great work! I'll go ahead and merge if you're happy with it.

@hoxbro
Copy link
Member

hoxbro commented Sep 28, 2022

Use bash instead of console

@droumis
Copy link
Member Author

droumis commented Sep 28, 2022 •
edited
Loading

@philippjfr , there are still some TODO's in here. Want me to remove them before the merge?

Update: I removed them

@philippjfr philippjfr merged commit f4c7c78 into master Sep 29, 2022
@philippjfr philippjfr deleted the dr/docs_getting_started branch September 29, 2022 08:59
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@philippjfr philippjfr philippjfr left review comments

@hoxbro hoxbro hoxbro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@droumis @hoxbro @codecov-commenter @philippjfr