Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the bikes example, I got the following errors:
This PR does three things:
Trying to debug this, I found it confusing with the combination of
os.path
andpathlib.Path
, so forsources/base.py
, I converted it all toPath
. I also setroot
up as a param, to always have it asPath
.The extension of the bikes URL
https://api.tfl.gov.uk/Occupancy/BikePoints/@{stations.stations.id}?app_key=a1c692de000b4944af55f59d8e849915
was before this PRid}?app_key=a1c692de000b4944af55f59d8e849915
and with this PRNone
dd.to_parquet
in_set_cache
first created a directory namedoccupancy.parq
withpart.0.parquet
files. This means that the final result fileoccupancy.parq
could not be saved as it was already a directory. This meant that the cache failed, gave the error message above and removed all the cache, which is not desired. I do it now by removing the extension if data is adask.DataFrame
. When loading in cache in_get_cache
I check for directories with and without the extension