Expose the disabled property of filters #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The goal with adding/improving the tests was to test that when a widget is disabled it is effectively ignored. I didn't manage in this attempt however to setup a test with a filter/source spec that creates what I wanted. |
philippjfr
reviewed
Oct 6, 2021
philippjfr
requested changes
Oct 6, 2021
|
Oh it almost went in with a default of
|
😆 I too missed that. I'll spend some time this week adding at least a basic set of unit tests. |
|
Merging and working on tests separately. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes
disabled, as done previously withvisible.get_datasubsequently ignores filters when they are disabled.