Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to expose View controls #137

Merged
merged 4 commits into from
Apr 15, 2021
Merged

Add ability to expose View controls #137

merged 4 commits into from
Apr 15, 2021

Conversation

philippjfr
Copy link
Member

Implements #124

The implementation I settled on is very explicit, each View now has a controls parameter which declares which parameters on the view will be exposed as widgets. This can either be set via the yaml specification or in the case of custom views a default value can be set which will expose those parameters. I'm much happier making this explicit rather than relying on any precedence or constant declaration since the author of a View cannot really know ahead of time which parameters it makes sense to expose.

To make this work well for parameters which reference fields in a table each View must declare _field_params. This allows the baseclass to know that it should populate the available options on this parameter with the available fields in the table so that the generated widgets offer a dropdown letting the user select between the available fields.

@philippjfr philippjfr merged commit 0b29e67 into master Apr 15, 2021
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant