compat: Matplotlib 3.10.1

[hoxbro]

The failing tests because of the updated UserWarning:

FAILED holoviews/tests/plotting/matplotlib/test_graphplot.py::TestMplGraphPlot::test_graph_op_node_color_linear - holoviews.core.options.AbbreviatedException: UserWarning: You passed both c and facecolor/facecolors for the markers. c has precedence over facecolor/facecolors. This behavior may change in the future.
FAILED holoviews/tests/plotting/matplotlib/test_graphplot.py::TestMplGraphPlot::test_graph_op_node_color_categorical - holoviews.core.options.AbbreviatedException: UserWarning: You passed both c and facecolor/facecolors for the markers. c has precedence over facecolor/facecolors. This behavior may change in the future.
FAILED holoviews/tests/plotting/matplotlib/test_graphplot.py::TestMplGraphPlot::test_graph_op_node_color_linear_update - holoviews.core.options.AbbreviatedException: UserWarning: You passed both c and facecolor/facecolors for the markers. c has precedence over facecolor/facecolors. This behavior may change in the future.
FAILED holoviews/tests/plotting/matplotlib/test_graphplot.py::TestMplGraphPlot::test_plot_graph_numerically_colored_nodes - holoviews.core.options.AbbreviatedException: UserWarning: You passed both c and facecolor/facecolors for the markers. c has precedence over facecolor/facecolors. This behavior may change in the future.
FAILED holoviews/tests/plotting/matplotlib/test_graphplot.py::TestMplChordPlot::test_chord_node_color_linear_style_mapping_update - holoviews.core.options.AbbreviatedException: UserWarning: You passed both c and facecolor/facecolors for the markers. c has precedence over facecolor/facecolors. This behavior may change in the future.
FAILED holoviews/tests/plotting/matplotlib/test_graphplot.py::TestMplChordPlot::test_chord_node_color_style_mapping - holoviews.core.options.AbbreviatedException: UserWarning: You passed both c and facecolor/facecolors for the markers. c has precedence over facecolor/facecolors. This behavior may change in the future.
FAILED holoviews/tests/plotting/matplotlib/test_graphplot.py::TestMplTriMeshPlot::test_trimesh_op_node_color_categorical - holoviews.core.options.AbbreviatedException: UserWarning: You passed both c and facecolor/facecolors for the markers. c has precedence over facecolor/facecolors. This behavior may change in the future.
FAILED holoviews/tests/plotting/matplotlib/test_graphplot.py::TestMplTriMeshPlot::test_trimesh_op_node_color_linear - holoviews.core.options.AbbreviatedException: UserWarning: You passed both c and facecolor/facecolors for the markers. c has precedence over facecolor/facecolors. This behavior may change in the future.

As far as I can see, we have relied on the behavior of c taking precedence over facecolor/facecolors, so here we just remove the values from the node options.

[hoxbro]

I don't think we need the MPL check here, but I'm not 100%, so I added it.

We could also use MPL_GE_3_10_0, as this has been tested, but could cause confusion...

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.79%. Comparing base (0ba7398) to head (819020b).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6526      +/-   ##
==========================================
+ Coverage   88.22%   88.79%   +0.57%     
==========================================
  Files         323      323              
  Lines       68946    68949       +3     
==========================================
+ Hits        60829    61225     +396     
+ Misses       8117     7724     -393     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[maximlt]

In which context is this warning triggered when using HoloViews? Is it when plotting some built-in elements?

Ignore this, I missed the first message. Unless there's a way to modify the plot objects that generate this error, I guess it's okay. Just to be sure, it does mean that users who pass c and facecolor together via .opts() won't get the warning, right?

[hoxbro]

A MRE is:

import holoviews as hv

hv.extension()

edges = [(0, 1)]
nodes = hv.Nodes([(0, 0, 0, 0.5), (0, 1, 1, 1.5)], vdims="color")
graph = hv.Graph((edges, nodes)).opts(node_color="color")
graph

Where facecolors is set here:

holoviews/holoviews/plotting/mpl/__init__.py

Line 297 in 0ba7398

options.Graph = Options('style', node_edgecolors='black', node_facecolors=Cycle(),

So it is because the default argument conflicts with node_color set by users.