Skip to content

Read crs from input files #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Read crs from input files #189

merged 1 commit into from
Feb 14, 2025

Conversation

uclaros
Copy link
Contributor

@uclaros uclaros commented Feb 14, 2025

This fixes a long standing issue, untwine is ignoring the input files' crs.
There have been related open issues in QGIS (eg qgis/QGIS#59662), however the issue has gone some times undetected due to QGIS reading the crs from the .las/.laz file when this is loaded instead of reading it from the copc.

To replicate:

$ pdal info --metadata test/data/autzen_trim.laz
# input file has crs
$ untwine -i test/data/autzen_trim.laz -o test/data/autzen_trim.copc.laz -s
$ pdal info --metadata test/data/autzen_trim.copc.laz
# output file has no crs :(

@hobu
Copy link
Collaborator

hobu commented Feb 14, 2025

What happens for a set of files with multiple different CRSs? The last one read will be used?

@abellgithub
Copy link
Collaborator

This is certainly a regression and shows that we need some tests.
@hobu The multiple SRS case should be handled (it was at one point), but again, there should be tests.

@abellgithub
Copy link
Collaborator

Amazing that this has been around for almost a year with no report.

@abellgithub abellgithub merged commit 82c5b9a into hobuinc:main Feb 14, 2025
6 checks passed
@uclaros uclaros deleted the fix-srs branch February 14, 2025 18:51
@uclaros
Copy link
Contributor Author

uclaros commented Feb 14, 2025

Now that you mention tests, I think the non ascii filename on windows bug is back :)
Scratch that, the issue is probably in QGIS as untwine.exe on the command prompt works correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants