Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update account menu to allow defining active link #24

Merged
merged 3 commits into from
Feb 21, 2019

Conversation

rpowis
Copy link
Contributor

@rpowis rpowis commented Feb 14, 2019

This allows the account menu items to be set as active.

  • Only account menu, messages, and check progress can be set as active
  • The account menu defaults to active if none are explicitly set

@nataliecarey
Copy link
Contributor

OK, on our side this looks good, what's the likely impact on users? Dynamically/conditionally setting a field on an object inside an array is more complex. As these items all have names should we use something more like active: "accountHome"?

To be clear - I think this interface is great for our side of the contract but I'm wondering how easy people will find it to consume.

@rpowis rpowis merged commit 9cde474 into master Feb 21, 2019
@rpowis rpowis deleted the SDT-1029-account-menu-active-item branch February 21, 2019 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants