SDT-879 Add Account header #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpowis
force-pushed
the
account-header
branch
from
65bb55d to
0038485
Compare
rpowis
force-pushed
the
account-header
branch
from
aa2e43b to
6cd3987
Compare
| - name: with-text | ||
| data: | ||
| text: New | ||
| badgeText: New |
There was a problem hiding this comment.
Is this related to the account header? What's the reason for breaking the text convention govuk are using?
There was a problem hiding this comment.
i wasn't aware that was a convention. it's badgeText in the prototype.
i thought badgeText made more sense, but we can change it back to text if preferred
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the Account Header as a layout file and styles.
There needs to be some follow up work to this in order to make the language select more dynamic and to add some tests for the layout file, but that would benefit from further discussion first.