Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Do not show Sign out link on timeout-dialog component if required #316

Closed
bsamray opened this issue Sep 8, 2023 · 4 comments
Closed

Comments

@bsamray
Copy link

bsamray commented Sep 8, 2023

We are using the HMRC session-timeout modal to warn users when their session is about to expire, and the solution is working well, but there is a requirement to hide the signOutButtonLink (as it is confusing to the users in our journey the way the page text have been set up). All we want to display is the Continue button to refresh the session, or alternatively the timer can count to 0 and then the session expires (i.e. user is not given the option to Sign out - we don't have a sign in feature in our journey - before the counter runs out). It doesn’t look like it’s possible to turn this link off - if we leave the nunjuck parameter blank or remove it then it just defaults to the value set in the HMRC code (i.e. Sign out).
With this issue, we aim to add a parameter to the component, just like many others such as signOutButtonText. This parameter, when set, shall result in not showing the 'Sign out' link on the modal timeout dialog.

bsamray pushed a commit to bsamray/hmrc-frontend that referenced this issue Sep 8, 2023
@oscarduignan
Copy link
Contributor

Hey @bsamray out of curiosity can I ask what service you're using it on- presumably outside hmrc? I've flagged this up internally, thank you for raising the request and sending a PR - we'll take a look at it next week and keep you updated

@bsamray
Copy link
Author

bsamray commented Sep 15, 2023 via email

@JoPintoPaul
Copy link
Contributor

Hi @bsamray, thank you for this contribution. We've now added your suggestion into the hmrc-frontend library, from v5.52.0 onwards.

@bsamray
Copy link
Author

bsamray commented Nov 1, 2023

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants