YTA-3215: Added endpoint for Payment History with Allocations. #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cybersaurus
force-pushed
the
feature/yta-3215
branch
from
4b06e03 to
e79239e
Compare
| val isTaxToCorrect2 = expectedTo2 == upperDate | ||
| (lowerDate.getMonthOfYear, lowerDate.getDayOfMonth) match { | ||
| case (m, 6) if isTaxToCorrect1 => Some(((m + 8) % 12) + 1) | ||
| case (m, 4) if isTaxToCorrect2 => Some(((m + 8) % 12) + 1) |
There was a problem hiding this comment.
Can we remove this exception? This was due to invalid data in QA and should never happen.
There was a problem hiding this comment.
Will do. This was copied from the backend. Should we remove the exception from there as well?
| "taxMonth": { | ||
| "$ref": "Definitions.schema.json#/definitions/taxMonth" | ||
| } | ||
| }, |
There was a problem hiding this comment.
Should have an amount field
| "amount": { | ||
| "description": "The first day of the tax year", | ||
| "type": "number" | ||
| }, |
There was a problem hiding this comment.
should have an unallocatedAmount field
cybersaurus
force-pushed
the
feature/yta-3215
branch
2 times, most recently
from
5710264 to
d7438f2
Compare
cybersaurus
force-pushed
the
feature/yta-3215
branch
from
d7438f2 to
3a490aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.