Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use v2.4.0.0 of clarity and stacks-common #275

Merged
merged 7 commits into from
Jun 8, 2023
Merged

Conversation

obycode
Copy link
Member

@obycode obycode commented Jun 6, 2023

No description provided.

@obycode obycode requested a review from jbencin June 6, 2023 21:37
@jbencin
Copy link
Member

jbencin commented Jun 7, 2023

Can you provide some description of what is going on here, particularly with the epoch logic? I don't understand these parts of the code well enough to review this without additional context

@obycode
Copy link
Member Author

obycode commented Jun 7, 2023

Looks like I forgot to push the last commit that fixes some things inside the testnet/stacks-node module. That is pushed now.

To answer your question @jbencin, the epochs are essentially gating consensus-breaking changes in the code, switching over at a specific block height to the new behavior. In the subnet, we just want to replicate the behavior of the latest epoch in the upstream blockchain. Some of the changes in this PR are to add those new epochs, and some are to adjust calls to the clarity or stacks-common crates which have been upgraded from version 2.1.0.0 to 2.4.0.0. Your question makes me think about whether the transitioning through these epochs in the subnet is happening correctly. I am double-checking that code now.

@obycode
Copy link
Member Author

obycode commented Jun 7, 2023

Ah, looks like there are still more changes needed in the tests related to the serialization/deserialization fixes. I'm fixing these now.

@obycode obycode force-pushed the feat/epoch-2.4 branch 3 times, most recently from 5a72e54 to ee94e2c Compare June 7, 2023 21:00
@saralab saralab self-requested a review June 8, 2023 16:32
Copy link
Contributor

@saralab saralab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@obycode obycode merged commit 05ea5ab into master Jun 8, 2023
@obycode obycode deleted the feat/epoch-2.4 branch June 8, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants