-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use v2.4.0.0 of clarity and stacks-common #275
Conversation
Can you provide some description of what is going on here, particularly with the epoch logic? I don't understand these parts of the code well enough to review this without additional context |
Looks like I forgot to push the last commit that fixes some things inside the testnet/stacks-node module. That is pushed now. To answer your question @jbencin, the epochs are essentially gating consensus-breaking changes in the code, switching over at a specific block height to the new behavior. In the subnet, we just want to replicate the behavior of the latest epoch in the upstream blockchain. Some of the changes in this PR are to add those new epochs, and some are to adjust calls to the clarity or stacks-common crates which have been upgraded from version 2.1.0.0 to 2.4.0.0. Your question makes me think about whether the transitioning through these epochs in the subnet is happening correctly. I am double-checking that code now. |
Ah, looks like there are still more changes needed in the tests related to the serialization/deserialization fixes. I'm fixing these now. |
5a72e54
to
ee94e2c
Compare
Ensure that the subnet just starts up in 2.4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.