Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/subnet contract versioning #274

Merged
merged 10 commits into from
Jun 6, 2023

Conversation

jbencin
Copy link
Member

@jbencin jbencin commented Jun 6, 2023

Description

Add Semver versioning to subnet.clar L1 contract. Also, check version of subnet.clar from application and multi-miner.clar

Applicable issues

Additional info (benefits, drawbacks, caveats)

  • In get_l1_contract_version(), I used an arbitrary address I pulled from test code for sender. Since this call is to a read-only function, I don't think it matters what is used here
  • This calls get_l1_contract_version() every time that submit_commit() is called to submit a block. Maybe this only has to be done once and cache the result?

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

@jbencin jbencin requested a review from obycode June 6, 2023 13:51
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #274 (5d34657) into master (377e3bc) will decrease coverage by 0.09%.
The diff coverage is 90.90%.

❗ Current head 5d34657 differs from pull request most recent head 7f12bc1. Consider uploading reports for the commit 7f12bc1 to get more accurate results

@@            Coverage Diff             @@
##           master     #274      +/-   ##
==========================================
- Coverage   93.49%   93.40%   -0.09%     
==========================================
  Files           6        6              
  Lines         338      349      +11     
==========================================
+ Hits          316      326      +10     
- Misses         22       23       +1     
Impacted Files Coverage Δ
core-contracts/contracts/multi-miner.clar 95.45% <90.00%> (-1.61%) ⬇️
core-contracts/contracts/subnet.clar 96.53% <100.00%> (+0.01%) ⬆️

Copy link
Member

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Jeff!

@jbencin jbencin merged commit 2402277 into hirosystems:master Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add versioning to L1 subnet.clar contract
2 participants