-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to subnets Getting Started and Overview guides #261
Conversation
Fixed a link, added some italics
Codecov Report
@@ Coverage Diff @@
## master #261 +/- ##
=======================================
Coverage 93.47% 93.47%
=======================================
Files 6 6
Lines 337 337
=======================================
Hits 315 315
Misses 22 22 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took a quick look and added a few comments. Also one general comment: Should we be consistently capitalizing all our product names like Subnets and Stacks.js?
Co-authored-by: jbencin <jeff.bencin@gmail.com>
Co-authored-by: jbencin <jeff.bencin@gmail.com>
Thanks Jeff, incorporated all your suggestions (and capitalized all instances of Stacks.js... I'm not sure why, but I think subnets has always been uncapitalized. Not sure why or who to confirm that with.) I believe we're good to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, made a couple more suggestions though that I missed the first time. I'll give @obycode an opportunity to review this as well, but if he's busy I can approve.
Also here's a general Markdown tip: Write one sentence per line. It will be rendered the same, but it makes git diff
s easier to read
cc: @LakshmiLavanyaKasturi — thanks Jeff! |
Co-authored-by: jbencin <jeff.bencin@gmail.com>
Co-authored-by: jbencin <jeff.bencin@gmail.com>
Description
Updates to subnets documentation, specifically the Getting Started guide and Overview page, the result of feedback.