feat: add block height to commit-block event
#260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kantai
approved these changes
Apr 18, 2023
obycode
force-pushed
the
add-block-height
branch
from
93c4dee to
326aae2
Compare
Codecov Report
@@ Coverage Diff @@
## master #260 +/- ##
==========================================
+ Coverage 93.47% 93.49% +0.01%
==========================================
Files 6 6
Lines 337 338 +1
==========================================
+ Hits 315 316 +1
Misses 22 22
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
The event generated by a `commit-block` (on the L1) now includes the block height for the block that is being committed, in the `block-height` key of the event tuple. The target burnchain block height now uses the key `target-burn-block-height`. This is useful for debugging, making it easy to match the L1 transactions with the L2 blocks. Note that this field is not checked in the tests since it is purely for convenience and could be left out of some implementations.
obycode
force-pushed
the
add-block-height
branch
from
326aae2 to
5002792
Compare
|
The last force push fixed the failing test. I'll merge once the tests all pass with this latest version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The event generated by a
commit-block(on the L1) now includes theblock height for the block that is being committed, in the
block-heightkey of the event tuple. The target burnchain block heightnow uses the key
target-burn-block-height. This is useful fordebugging, making it easy to match the L1 transactions with the L2
blocks. Note that this field is not checked in the tests since it is
purely for convenience and could be left out of some implementations.