Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support versioned contract transactions #257

Merged
merged 2 commits into from
Apr 18, 2023
Merged

Conversation

obycode
Copy link
Member

@obycode obycode commented Apr 18, 2023

The upstream changes for 2.1 added support to pass the Clarity version when deploying a contract. Using this new transaction type is the default from stacks.js, so it makes sense to support this new type in the subnet as well.

@obycode obycode requested a review from jbencin April 18, 2023 02:02
@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #257 (dd9f3dd) into fix/respect-first-burn-ht (7d373f0) will not change coverage.
The diff coverage is n/a.

@@                    Coverage Diff                     @@
##           fix/respect-first-burn-ht     #257   +/-   ##
==========================================================
  Coverage                      93.47%   93.47%           
==========================================================
  Files                              6        6           
  Lines                            337      337           
==========================================================
  Hits                             315      315           
  Misses                            22       22           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@jbencin jbencin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only one minor suggestion

@obycode obycode force-pushed the fix/respect-first-burn-ht branch from ffb02a2 to 7d373f0 Compare April 18, 2023 14:02
@obycode obycode force-pushed the fix/versioned-contract branch from 528c222 to dd9f3dd Compare April 18, 2023 14:50
Copy link
Member

@jbencin jbencin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Base automatically changed from fix/respect-first-burn-ht to master April 18, 2023 16:45
obycode and others added 2 commits April 18, 2023 12:46
The upstream changes for 2.1 added support to pass the Clarity version
when deploying a contract. Using this new transaction type is the
default from stacks.js, so it makes sense to support this new type in
the subnet as well.
Co-authored-by: jbencin <jeff.bencin@gmail.com>
@obycode obycode force-pushed the fix/versioned-contract branch from dd9f3dd to b2113ae Compare April 18, 2023 16:46
@obycode obycode merged commit 0ba9c3e into master Apr 18, 2023
@obycode obycode deleted the fix/versioned-contract branch April 18, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants