Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: handful of resiliency fixes #252

Merged
merged 6 commits into from
Apr 18, 2023
Merged

Fix: handful of resiliency fixes #252

merged 6 commits into from
Apr 18, 2023

Conversation

kantai
Copy link
Contributor

@kantai kantai commented Apr 7, 2023

This PR fixes a handful of issues that cropped up while running on testnet.

  1. Ignoring L1 blocks before the first block height: this ensures that if a reorg occurs before the first block height, the node doesn't need to backtrack (potentially through blocks it hasn't received data for).
  2. The neon run loop needs to increment the "target_burnchain_block", even without PoX reward cycles. To do this, we just use a constant value.
  3. On restarting a paired stacks-node and subnet-node, the stacks-node may re-broadcast the last event it broadcasted. In such cases, the subnet-node should just drop the duplicate data.
  4. The p2p inventory sync needs to send GetBlockInv messages even though the PoX reward cycle sync is broken in subnets (because there's no PoX cycles!)

@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Merging #252 (7d373f0) into master (b32b7eb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #252   +/-   ##
=======================================
  Coverage   93.47%   93.47%           
=======================================
  Files           6        6           
  Lines         337      337           
=======================================
  Hits          315      315           
  Misses         22       22           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@obycode obycode force-pushed the fix/respect-first-burn-ht branch from ffb02a2 to 7d373f0 Compare April 18, 2023 14:02
Copy link
Member

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@obycode obycode merged commit 1bfbaeb into master Apr 18, 2023
@obycode obycode deleted the fix/respect-first-burn-ht branch April 18, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants