Withdrawal height #228
Merged
Withdrawal height #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`stx-wtihdraw?`, `ft-withdraw?` and `nft-withdraw?` do not return any meaningful value on success. When attempting to make a withdrawal, users will need the block height in which the withdrawal occured in order to perform the second stage of the withdraw (on the L1). This changeset makes these withdraw functions return the block height for convenience.
In addition to returning the withdraw height from the `-withdraw?` functions, this commit adds this height to the print event as well.
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #228 +/- ##
===========================================
+ Coverage 0 92.26% +92.26%
===========================================
Files 0 6 +6
Lines 0 336 +336
===========================================
+ Hits 0 310 +310
- Misses 0 26 +26
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
kantai
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return the block height of the withdrawal from the
-withdraw?functions and add it to the print event.