Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Fix some flaky tests #214

Merged
merged 2 commits into from
Feb 16, 2023
Merged

Conversation

jbencin
Copy link
Member

@jbencin jbencin commented Feb 15, 2023

Description

Fix a couple flaky CI tests. The tests fixed are the ones that have been failingin recent PRs that couldn't be explained by problems with the PR itself. Relevant tests are described in linked issue. As far as I can tell, all tests seem to pass now

Applicable issues

Additional info (benefits, drawbacks, caveats)

This PR may not fix all flaky tests, but it fixes the most common failures, so I'd like to get it merged and close this issue. If any more flaky tests are discovered, we should create a new issue for each test with relevant error logs, rather than trying to address them all in one issue/PR.

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

@codecov-commenter
Copy link

Codecov Report

Merging #214 (85c6b71) into master (54c653c) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master     #214   +/-   ##
=======================================
  Coverage   91.19%   91.19%           
=======================================
  Files           6        6           
  Lines         284      284           
=======================================
  Hits          259      259           
  Misses         25       25           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jbencin jbencin changed the title Run CI test fix(ci): Fix some flaky tests Feb 16, 2023
@jbencin jbencin marked this pull request as ready for review February 16, 2023 18:18
Copy link
Member

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jbencin jbencin merged commit b56103d into hirosystems:master Feb 16, 2023
@jbencin jbencin deleted the fix/flaky-ci-tests branch February 16, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky tests
3 participants