-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In-memory prototype of MARF replace (SOAR-DB!) #213
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall very nice code! I've only got a couple minor comments:
- It seems like a lot of dependencies are declared in
Cargo.toml
but not used - I'd recommend putting
//!
comments at the top of each file, it makes navigating documentation easier
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #213 +/- ##
==========================================
+ Coverage 91.19% 92.04% +0.85%
==========================================
Files 6 6
Lines 284 327 +43
==========================================
+ Hits 259 301 +42
- Misses 25 26 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Thanks for the review! I eliminated the unused dependencies (which aren't getting used in a subsequent PR) and also added rustdoc inline ( |
Description
This PR implements an in-memory optimistic fork-aware data store, for replacing the MARF. The general idea with the datastore is to store the current data view as a normal key-value store and track the history of operations on the storage. When a fork occurs, the data state is unwound and then replayed.
This first PR just implements and tests a simple in-memory version of the data store, which unblocks work on integrating the db with the rest of the subnet node (that work is ongoing in the
feat/soar-db
branch.