Updates to mint with trait and various minor changes #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll fix those tests. I imagine they should just need some updates to match the changes I made. |
|
Ok, I went through and resolved the remaining issues, and fixed the tests. Now I am going through the NFT use case demo and making any changes necessary to the readme or scripts. |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #206 +/- ##
==========================================
+ Coverage 91.19% 92.04% +0.85%
==========================================
Files 6 6
Lines 284 327 +43
==========================================
+ Hits 259 301 +42
- Misses 25 26 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
7 tasks
Closed
obycode
force-pushed
the
mint-with-trait
branch
from
5c91e8a to
6e3aff3
Compare
- Change allowed-contracts map to hold the principal of the L2 contract instead of the name of the deposit function. This is thanks to the use of a trait for deposits instead, which simplifies things. - Pass contract as first arg for deposit/withdrawal methods - Reformat clarity contracts - Update unit tests - Reformat unit tests
Use "deposit-from-burnchain" always, because it will be validated by a trait.
These should have been included in the previous commits.
These will be used by clarinet to deploy the contracts to devnet.
obycode
force-pushed
the
mint-with-trait
branch
from
5a927ed to
2e40b5d
Compare
obycode
force-pushed
the
mint-with-trait
branch
from
2e40b5d to
4a629c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of the name of the deposit function. This is thanks to the use
of a trait for deposits instead, which simplifies things.