Withdrawal entry RPC and fixes #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…add testing to rpc and event changes in l1_observer_test
Codecov Report
@@ Coverage Diff @@
## master #116 +/- ##
==========================================
+ Coverage 78.09% 78.23% +0.13%
==========================================
Files 261 262 +1
Lines 171195 171344 +149
==========================================
+ Hits 133696 134050 +354
+ Misses 37499 37294 -205
Continue to review full report at Codecov.
|
pavitthrap
approved these changes
Jun 14, 2022
Comment on lines
+46
to
+47
| node ./publish_tx.js ft-trait-standard ../contracts/ft-trait-standard.clar 0 > ../transactions/ft-publish.hex | ||
| node ./publish_tx.js nft-trait-standard ../contracts/nft-trait-standard.clar 1 > ../transactions/nft-publish.hex |
There was a problem hiding this comment.
when my nft use case integration test pr merges, I'll update these instructions
clarity/src/vm/events.rs
Outdated
| @@ -339,6 +342,7 @@ impl NFTWithdrawEventData { | |||
| "sender": format!("{}",self.sender), | |||
| "value": self.value, | |||
| "raw_value": format!("0x{}", raw_value.join("")), | |||
| "withdrawal_id": self.withdrawal_id.unwrap_or(0), | |||
There was a problem hiding this comment.
not sure if it makes sense to default to 0 in these serializations here (since 0 is a valid id)
There was a problem hiding this comment.
Switched these methods in 30cca56 to return Options, so that the caller can choose to either error or panic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
withdrawal_idin withdrawal events #115)RunTenuredirective in theneon_node: the miner always mines off of the burnchain tip when it receives a directive, so it does not need to be passed via the directive channel.