fix(brc20): verify ordinal transfers in chunks instead of individually #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
rafaelcr
had a problem deploying
to
Development-mainnet-blue
GitHub Actions
Error
rafaelcr
had a problem deploying
to
Development-mainnet-blue
GitHub Actions
Error
ASuciuX
reviewed
Feb 5, 2025
components/ordhook-core/src/core/meta_protocols/brc20/brc20_pg.rs
Outdated
Show resolved
Hide resolved
components/ordhook-core/src/core/meta_protocols/brc20/brc20_pg.rs
Outdated
Show resolved
Hide resolved
|
Thanks @ASuciuX ! Please take another look |
rafaelcr
had a problem deploying
to
Development-mainnet-blue
GitHub Actions
Failure
github-actions bot
pushed a commit
that referenced
this pull request
Feb 13, 2025
## [3.0.0-beta.6](v3.0.0-beta.5...v3.0.0-beta.6) (2025-02-13) ### Features * migrate ordinals api to ordhook repo ([#389](#389)) ([205b4c8](205b4c8)) ### Bug Fixes * **brc20:** verify ordinal transfers in chunks instead of individually ([#394](#394)) ([fe842e2](fe842e2)) * clean up rocksdb connections during rollbacks ([#420](#420)) ([216cd52](216cd52)) * remove double parsing of inscriptions ([#421](#421)) ([19c8a79](19c8a79)) * upgrade `ord` dependencies and integrate `chainhook-sdk` code ([#397](#397)) ([fcffa7e](fcffa7e)), closes [#412](#412)
github-actions bot
pushed a commit
that referenced
this pull request
Mar 6, 2025
## [3.0.0](v2.2.5...v3.0.0) (2025-03-06) ### ⚠ BREAKING CHANGES * store inscription data in postgres instead of sqlite (#375) * support brc20 activity on scan blocks command (#350) * keep original deployed ticker for brc20 tokens (#349) ### Features * add prometheus monitoring ([#356](#356)) ([f35e1d0](f35e1d0)) * **api:** add parent_refs field to inscription responses ([#436](#436)) ([5630644](5630644)) * **api:** return inscription charms in responses ([#435](#435)) ([a7073da](a7073da)) * index inscription charms ([#433](#433)) ([4291eab](4291eab)) * keep original deployed ticker for brc20 tokens ([#349](#349)) ([39774a9](39774a9)) * migrate ordinals api to ordhook repo ([#389](#389)) ([205b4c8](205b4c8)) * **runes:** add runes api to codebase ([#449](#449)) ([da5596a](da5596a)) * **runes:** add runes indexer ([#453](#453)) ([fd2a849](fd2a849)) * support a separate storage directory for observers.sqlite ([#354](#354)) ([7a65fdf](7a65fdf)) * support brc20 activity on scan blocks command ([#350](#350)) ([caacff7](caacff7)) * wait for bitcoind to be at chain tip before starting service ([#364](#364)) ([d4b67bb](d4b67bb)) ### Bug Fixes * also check config when looking for brc20 db connection ([#347](#347)) ([d80388b](d80388b)) * **api:** multiple parent display ([703f98f](703f98f)) * **api:** show delegate inscription id correctly ([#439](#439)) ([d4ee264](d4ee264)) * **brc20:** add to_address index to operations table ([#390](#390)) ([67c6035](67c6035)) * **brc20:** historical token balance ([#444](#444)) ([41438ac](41438ac)) * **brc20:** verify ordinal transfers in chunks instead of individually ([#394](#394)) ([fe842e2](fe842e2)) * calculate charms correctly when inscription is unbound ([#440](#440)) ([acfda83](acfda83)) * clean up rocksdb connections during rollbacks ([#420](#420)) ([216cd52](216cd52)) * display unbound inscription satpoints as all zeros with unbound sequence as offset ([#445](#445)) ([6815878](6815878)) * kill process when a streamed block fails to index ([#431](#431)) ([84e189b](84e189b)) * only create brc-20 db connection and cache if required ([#357](#357)) ([5692426](5692426)) * **ordinals:** track multiple sat transfers in the same block correctly ([#460](#460)) ([b611ff3](b611ff3)) * remove double parsing of inscriptions ([#421](#421)) ([19c8a79](19c8a79)) * roll back ordinals db changes when brc20 db commit fails ([#367](#367)) ([f4e0c79](f4e0c79)) * store inscription content as is ([#391](#391)) ([3f10607](3f10607)) * upgrade `ord` dependencies and integrate `chainhook-sdk` code ([#397](#397)) ([fcffa7e](fcffa7e)), closes [#412](#412) ### Code Refactoring * store inscription data in postgres instead of sqlite ([#375](#375)) ([4afb201](4afb201))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Bitcoin blocks contain tens of thousands (or hundreds of thousands) of ordinal transfers. The BRC-20 indexer needs to look at each of these to see if any
transferoperation was sent to another address (thus generating atransfer_sendoperation). This is currently extremely slow on our production deployments because it represents 1 roundtrip to postgres for every transfer we need to check.This PR makes sure that when we analyze these we do so in chunks in order to minimize the roundtrip overhead to and from postgres thus making indexing much faster.