fix: also check config when looking for brc20 db connection (#347)

Author: rafaelcr

components/ordhook-cli/src/cli/mod.rs

@@ -35,7 +35,7 @@ use ordhook::scan::bitcoin::scan_bitcoin_chainstate_via_rpc_using_predicate;
 use ordhook::service::observers::initialize_observers_db;
 use ordhook::service::{start_observer_forwarding, Service};
 use ordhook::utils::bitcoind::bitcoind_get_block_height;
-use ordhook::{hex, initialize_db};
+use ordhook::{hex, initialize_databases};
 use reqwest::Client as HttpClient;
 use std::collections::HashSet;
 use std::io::{BufReader, Read};
@@ -586,7 +586,7 @@ async fn handle_command(opts: Opts, ctx: &Context) -> Result<(), String> {
                 let mut total_inscriptions = 0;
                 let mut total_transfers = 0;
 
-                let db_connections = initialize_db(&config, ctx);
+                let db_connections = initialize_databases(&config, ctx);
                 let inscriptions_db_conn = db_connections.ordhook;
                 while let Some(block_height) = block_range.pop_front() {
                     let inscriptions =
@@ -704,16 +704,12 @@ async fn handle_command(opts: Opts, ctx: &Context) -> Result<(), String> {
 
                 let config =
                     ConfigFile::default(cmd.regtest, cmd.testnet, cmd.mainnet, &cmd.config_path)?;
-
-                initialize_db(&config, ctx);
-
-                let inscriptions_db_conn =
-                    open_readonly_ordhook_db_conn(&config.expected_cache_path(), ctx)?;
+                let db_connections = initialize_databases(&config, ctx);
 
                 let last_known_block =
-                    find_latest_inscription_block_height(&inscriptions_db_conn, ctx)?;
+                    find_latest_inscription_block_height(&db_connections.ordhook, ctx)?;
                 if last_known_block.is_none() {
-                    // Create DB
+                    // Create rocksdb
                     open_ordhook_db_conn_rocks_db_loop(
                         true,
                         &config.expected_cache_path(),
@@ -746,7 +742,6 @@ async fn handle_command(opts: Opts, ctx: &Context) -> Result<(), String> {
                 };
 
                 let mut predicates = vec![];
-
                 for post_to in cmd.post_to.iter() {
                     let predicate = build_predicate_from_cli(
                         &config,
@@ -788,7 +783,7 @@ async fn handle_command(opts: Opts, ctx: &Context) -> Result<(), String> {
         Command::Db(OrdhookDbCommand::New(cmd)) => {
             let config = ConfigFile::default(false, false, false, &cmd.config_path)?;
             // Create DB
-            initialize_db(&config, ctx);
+            initialize_databases(&config, ctx);
             open_ordhook_db_conn_rocks_db_loop(
                 true,
                 &config.expected_cache_path(),
@@ -799,7 +794,7 @@ async fn handle_command(opts: Opts, ctx: &Context) -> Result<(), String> {
         }
         Command::Db(OrdhookDbCommand::Sync(cmd)) => {
             let config = ConfigFile::default(false, false, false, &cmd.config_path)?;
-            initialize_db(&config, ctx);
+            initialize_databases(&config, ctx);
             let service = Service::new(config, ctx.clone());
             service.update_state(None).await?;
         }

components/ordhook-core/src/core/mod.rs

@@ -13,6 +13,7 @@ use chainhook_sdk::utils::Context;
 use crate::{
     config::{Config, LogConfig, MetaProtocolsConfig, ResourcesConfig},
     db::{find_pinned_block_bytes_at_block_height, open_ordhook_db_conn_rocks_db_loop},
+    initialize_databases,
     utils::bitcoind::bitcoind_get_block_height,
 };
 
@@ -152,7 +153,7 @@ pub fn should_sync_ordhook_db(
     let mut start_block = find_last_block_inserted(&blocks_db) as u64;
 
     if start_block == 0 {
-        let _ = initialize_ordhook_db(&config.expected_cache_path(), &ctx);
+        let _ = initialize_databases(config, ctx);
     }
 
     let inscriptions_db_conn = open_readonly_ordhook_db_conn(&config.expected_cache_path(), &ctx)?;

components/ordhook-core/src/lib.rs

@@ -36,7 +36,9 @@ pub struct DbConnections {
     pub brc20: Option<Connection>,
 }
 
-pub fn initialize_db(config: &Config, ctx: &Context) -> DbConnections {
+/// Initializes all SQLite databases required for Ordhook operation, depending if they are requested by the current `Config`.
+/// Returns a struct with all the open connections.
+pub fn initialize_databases(config: &Config, ctx: &Context) -> DbConnections {
     DbConnections {
         ordhook: initialize_ordhook_db(&config.expected_cache_path(), ctx),
         brc20: match config.meta_protocols.brc20 {

components/ordhook-core/src/scan/bitcoin.rs

@@ -7,6 +7,7 @@ use crate::core::protocol::inscription_parsing::{
 use crate::core::protocol::inscription_sequencing::consolidate_block_with_pre_computed_ordinals_data;
 use crate::db::{get_any_entry_in_ordinal_activities, open_readonly_ordhook_db_conn};
 use crate::download::download_ordinals_dataset_if_required;
+use crate::initialize_databases;
 use crate::service::observers::{
     open_readwrite_observers_db_conn_or_panic, update_observer_progress,
 };
@@ -76,15 +77,14 @@ pub async fn scan_bitcoin_chainstate_via_rpc_using_predicate(
     let http_client = build_http_client();
 
     while let Some(current_block_height) = block_heights_to_scan.pop_front() {
-        let mut inscriptions_db_conn =
-            open_readonly_ordhook_db_conn(&config.expected_cache_path(), ctx)?;
+        // Open DB connections
+        let db_connections = initialize_databases(&config, ctx);
+        let mut inscriptions_db_conn = db_connections.ordhook;
         let brc20_db_conn = match predicate_spec.predicate {
+            // Even if we have a valid BRC-20 DB connection, check if the predicate we're evaluating requires us to do the work.
             BitcoinPredicateType::OrdinalsProtocol(OrdinalOperations::InscriptionFeed(
                 ref feed_data,
-            )) if feed_data.meta_protocols.is_some() => Some(open_readonly_brc20_db_conn(
-                &config.expected_cache_path(),
-                ctx,
-            )?),
+            )) if feed_data.meta_protocols.is_some() => db_connections.brc20,
             _ => None,
         };
 
@@ -232,9 +232,7 @@ pub async fn execute_predicates_action<'a>(
                     BitcoinChainhookOccurrence::Http(request, _data) => {
                         send_request(request, 60, 3, &ctx).await
                     }
-                    BitcoinChainhookOccurrence::File(path, bytes) => {
-                        file_append(path, bytes, &ctx)
-                    }
+                    BitcoinChainhookOccurrence::File(path, bytes) => file_append(path, bytes, &ctx),
                     BitcoinChainhookOccurrence::Data(payload) => {
                         if let Some(ref tx) = config.data_handler_tx {
                             match tx.send(DataHandlerEvent::Process(payload)) {
@@ -247,7 +245,7 @@ pub async fn execute_predicates_action<'a>(
                     }
                 };
                 match result {
-                    Ok(_) => {},
+                    Ok(_) => {}
                     Err(error) => return Err(error),
                 }
             }