Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wait for bitcoind to be at chain tip before starting service #364

Merged
merged 3 commits into from
Sep 20, 2024

Conversation

rafaelcr
Copy link
Collaborator

Before starting either the indexing service or a DB index sync, check that bitcoind is at chain tip relative to its peers. This allows us to boot up ordhook at the same time as a Bitcoin node even if that node is behind the Bitcoin chain tip.

Fixes #289

Copy link

@bgridley bgridley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
components/ordhook-core/src/utils/bitcoind.rs 0.00% 18 Missing ⚠️
components/ordhook-core/src/service/mod.rs 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@rafaelcr rafaelcr had a problem deploying to Development-mainnet-blue September 20, 2024 17:02 — with GitHub Actions Error
@rafaelcr rafaelcr had a problem deploying to Development-mainnet-blue September 20, 2024 17:27 — with GitHub Actions Failure
@rafaelcr rafaelcr merged commit d4b67bb into develop Sep 20, 2024
5 of 7 checks passed
@rafaelcr rafaelcr deleted the fix/wait-for-ibd branch September 20, 2024 17:34
github-actions bot pushed a commit that referenced this pull request Sep 20, 2024
## [3.0.0-beta.1](v2.2.5...v3.0.0-beta.1) (2024-09-20)

### ⚠ BREAKING CHANGES

* support brc20 activity on scan blocks command (#350)
* keep original deployed ticker for brc20 tokens (#349)

### Features

* add prometheus monitoring ([#356](#356)) ([f35e1d0](f35e1d0))
* keep original deployed ticker for brc20 tokens ([#349](#349)) ([39774a9](39774a9))
* support a separate storage directory for observers.sqlite ([#354](#354)) ([7a65fdf](7a65fdf))
* support brc20 activity on scan blocks command ([#350](#350)) ([caacff7](caacff7))
* wait for bitcoind to be at chain tip before starting service ([#364](#364)) ([d4b67bb](d4b67bb))

### Bug Fixes

* also check config when looking for brc20 db connection ([#347](#347)) ([d80388b](d80388b))
* only create brc-20 db connection and cache if required ([#357](#357)) ([5692426](5692426))
github-actions bot pushed a commit that referenced this pull request Mar 6, 2025
## [3.0.0](v2.2.5...v3.0.0) (2025-03-06)

### ⚠ BREAKING CHANGES

* store inscription data in postgres instead of sqlite (#375)
* support brc20 activity on scan blocks command (#350)
* keep original deployed ticker for brc20 tokens (#349)

### Features

* add prometheus monitoring ([#356](#356)) ([f35e1d0](f35e1d0))
* **api:** add parent_refs field to inscription responses ([#436](#436)) ([5630644](5630644))
* **api:** return inscription charms in responses ([#435](#435)) ([a7073da](a7073da))
* index inscription charms ([#433](#433)) ([4291eab](4291eab))
* keep original deployed ticker for brc20 tokens ([#349](#349)) ([39774a9](39774a9))
* migrate ordinals api to ordhook repo ([#389](#389)) ([205b4c8](205b4c8))
* **runes:** add runes api to codebase ([#449](#449)) ([da5596a](da5596a))
* **runes:** add runes indexer ([#453](#453)) ([fd2a849](fd2a849))
* support a separate storage directory for observers.sqlite ([#354](#354)) ([7a65fdf](7a65fdf))
* support brc20 activity on scan blocks command ([#350](#350)) ([caacff7](caacff7))
* wait for bitcoind to be at chain tip before starting service ([#364](#364)) ([d4b67bb](d4b67bb))

### Bug Fixes

* also check config when looking for brc20 db connection ([#347](#347)) ([d80388b](d80388b))
* **api:** multiple parent display ([703f98f](703f98f))
* **api:** show delegate inscription id correctly ([#439](#439)) ([d4ee264](d4ee264))
* **brc20:** add to_address index to operations table ([#390](#390)) ([67c6035](67c6035))
* **brc20:** historical token balance ([#444](#444)) ([41438ac](41438ac))
* **brc20:** verify ordinal transfers in chunks instead of individually ([#394](#394)) ([fe842e2](fe842e2))
* calculate charms correctly when inscription is unbound ([#440](#440)) ([acfda83](acfda83))
* clean up rocksdb connections during rollbacks ([#420](#420)) ([216cd52](216cd52))
* display unbound inscription satpoints as all zeros with unbound sequence as offset ([#445](#445)) ([6815878](6815878))
* kill process when a streamed block fails to index ([#431](#431)) ([84e189b](84e189b))
* only create brc-20 db connection and cache if required ([#357](#357)) ([5692426](5692426))
* **ordinals:** track multiple sat transfers in the same block correctly ([#460](#460)) ([b611ff3](b611ff3))
* remove double parsing of inscriptions ([#421](#421)) ([19c8a79](19c8a79))
* roll back ordinals db changes when brc20 db commit fails ([#367](#367)) ([f4e0c79](f4e0c79))
* store inscription content as is ([#391](#391)) ([3f10607](3f10607))
* upgrade `ord` dependencies and integrate `chainhook-sdk` code ([#397](#397)) ([fcffa7e](fcffa7e)), closes [#412](#412)

### Code Refactoring

* store inscription data in postgres instead of sqlite ([#375](#375)) ([4afb201](4afb201))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Improve resiliency regarding underlying bitcoind
2 participants