Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: README.md. Removed depends_on() field in the clarinet.toml file and added success message for clarinet check command. #440

Conversation

LakshmiLavanyaKasturi
Copy link
Contributor

  1. Removed depends_on = [] as it is no longer part of the clarinet.toml file
  2. Updated clarinet.toml file config for bbtc.clar and my-contract.clar.
  3. Changed the checked contracts to 2 as the default count is 2 contracts.
  4. 'clarinet check hiro-coin.clar' changed to clarinet check <path/to/file.clar> for more clarity.

@codecov-commenter
Copy link

Codecov Report

Merging #440 (0a29310) into develop (be49466) will increase coverage by 12.16%.
The diff coverage is 37.07%.

@@             Coverage Diff              @@
##           develop     #440       +/-   ##
============================================
+ Coverage     9.45%   21.62%   +12.16%     
============================================
  Files           55      165      +110     
  Lines        12266    40458    +28192     
============================================
+ Hits          1160     8748     +7588     
- Misses       11106    31710    +20604     
Flag Coverage Δ
unittests 21.62% <37.07%> (+12.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/clarinet-deployments/src/lib.rs 46.25% <0.00%> (-0.32%) ⬇️
components/clarinet-deployments/src/types.rs 0.44% <0.00%> (-0.03%) ⬇️
components/clarinet-files/src/network_manifest.rs 36.63% <0.00%> (ø)
components/clarity-repl/src/analysis/annotation.rs 0.00% <0.00%> (ø)
...nts/clarity-repl/src/analysis/check_checker/mod.rs 56.51% <ø> (ø)
...clarity/analysis/type_checker/natives/sequences.rs 0.00% <0.00%> (ø)
components/clarity-repl/src/clarity/clarity.rs 0.00% <0.00%> (ø)
...omponents/clarity-repl/src/clarity/codec/macros.rs 0.00% <0.00%> (ø)
components/clarity-repl/src/clarity/codec/mod.rs 0.00% <0.00%> (ø)
...ents/clarity-repl/src/clarity/codec/transaction.rs 0.00% <0.00%> (ø)
... and 130 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13f6d2c...0a29310. Read the comment docs.

Copy link
Member

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're trying to follow Conventional Commits to help with auto-generated changelogs. Please update your commit messages to begin with docs: . It would also be helpful to include more info in the message, such as the items in your comment on this PR.

https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/changing-a-commit-message

@LakshmiLavanyaKasturi LakshmiLavanyaKasturi changed the title Readme.md updates docs: README.md updates based on the current project workflow. Jul 11, 2022
@LakshmiLavanyaKasturi
Copy link
Contributor Author

We're trying to follow Conventional Commits to help with auto-generated changelogs. Please update your commit messages to begin with docs: . It would also be helpful to include more info in the message, such as the items in your comment on this PR.

https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/changing-a-commit-message

@obycode Please let me know if the commit message looks good now. Thanks.

… and added success message for clarinet check command.
@LakshmiLavanyaKasturi LakshmiLavanyaKasturi changed the title docs: README.md updates based on the current project workflow. docs: README.md. Removed depends_on() field in the clarinet.toml file and added success message for clarinet check command. Jul 11, 2022
Copy link
Member

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LakshmiLavanyaKasturi LakshmiLavanyaKasturi merged commit 37c5bc7 into hirosystems:develop Jul 12, 2022
@LakshmiLavanyaKasturi LakshmiLavanyaKasturi deleted the clarinet-contract branch July 12, 2022 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants