Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: revisit fork handling #429

Merged
merged 61 commits into from
Jul 11, 2022
Merged

Feat: revisit fork handling #429

merged 61 commits into from
Jul 11, 2022

Conversation

lgalabru
Copy link
Contributor

@lgalabru lgalabru commented Jun 24, 2022

In this PR, we are improving the Oreo's ability to relay a consistent view of the chain, by supporting forks and unexpected network behaviors.
We were able to live without it in Clarinet because clarinet integrate spins up local, solo-mining networks - not supposed to be adversarial.
Thanks to this effort, chainhooks can now reasonably be used on other networks like Testnet and Mainnet.
I'm planning on opening a subsequent PR with an additional batch of 50 vectors, probably end of next week.

@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2022

Codecov Report

Merging #429 (aa99c87) into develop (be49466) will increase coverage by 12.16%.
The diff coverage is 37.07%.

@@             Coverage Diff              @@
##           develop     #429       +/-   ##
============================================
+ Coverage     9.45%   21.62%   +12.16%     
============================================
  Files           55      165      +110     
  Lines        12266    40458    +28192     
============================================
+ Hits          1160     8748     +7588     
- Misses       11106    31710    +20604     
Flag Coverage Δ
unittests 21.62% <37.07%> (+12.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/clarinet-deployments/src/lib.rs 46.25% <0.00%> (-0.32%) ⬇️
components/clarinet-deployments/src/types.rs 0.44% <0.00%> (-0.03%) ⬇️
components/clarinet-files/src/network_manifest.rs 36.63% <0.00%> (ø)
components/clarity-repl/src/analysis/annotation.rs 0.00% <0.00%> (ø)
...nts/clarity-repl/src/analysis/check_checker/mod.rs 56.51% <ø> (ø)
...clarity/analysis/type_checker/natives/sequences.rs 0.00% <0.00%> (ø)
components/clarity-repl/src/clarity/clarity.rs 0.00% <0.00%> (ø)
...omponents/clarity-repl/src/clarity/codec/macros.rs 0.00% <0.00%> (ø)
components/clarity-repl/src/clarity/codec/mod.rs 0.00% <0.00%> (ø)
...ents/clarity-repl/src/clarity/codec/transaction.rs 0.00% <0.00%> (ø)
... and 136 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13f6d2c...aa99c87. Read the comment docs.

@lgalabru lgalabru marked this pull request as ready for review July 7, 2022 09:52
@lgalabru lgalabru requested review from obycode and hugocaillard July 7, 2022 09:53
Copy link
Member

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! Mostly minor comments.

@lgalabru lgalabru requested a review from obycode July 8, 2022 18:43
obycode
obycode previously approved these changes Jul 8, 2022
Copy link
Member

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lgalabru lgalabru merged commit 293fbe1 into develop Jul 11, 2022
@lgalabru lgalabru deleted the feat/revisit-fork-handling branch July 11, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants