-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: revisit fork handling #429
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #429 +/- ##
============================================
+ Coverage 9.45% 21.62% +12.16%
============================================
Files 55 165 +110
Lines 12266 40458 +28192
============================================
+ Hits 1160 8748 +7588
- Misses 11106 31710 +20604
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good! Mostly minor comments.
vendor/orchestra-event-observer/src/indexer/bitcoin/blocks_pool.rs
Outdated
Show resolved
Hide resolved
vendor/orchestra-event-observer/src/indexer/stacks/blocks_pool.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
In this PR, we are improving the Oreo's ability to relay a consistent view of the chain, by supporting forks and unexpected network behaviors.
We were able to live without it in Clarinet because
clarinet integrate
spins up local, solo-mining networks - not supposed to be adversarial.Thanks to this effort, chainhooks can now reasonably be used on other networks like Testnet and Mainnet.
I'm planning on opening a subsequent PR with an additional batch of 50 vectors, probably end of next week.