Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix define-trait format w/ test #1691

Merged
merged 2 commits into from
Feb 24, 2025
Merged

Conversation

tippenein
Copy link
Collaborator

@tippenein tippenein commented Feb 21, 2025

New format

(define-trait token-trait
  (
    (transfer? (principal principal uint) (response uint uint)) ;; comment
    (get-balance (principal) (response uint uint))
  )
)

Extra fixes included (from #1689 (comment)):

  • fix un-stylized principal value
  • remove some nasty old constant formatting and use the same generic code for all of them (define-nft/constant/ft etc...)

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@tippenein tippenein force-pushed the chore/fix-define-trait branch from c117f91 to 56c9f27 Compare February 21, 2025 03:38
Copy link
Collaborator

@hugocaillard hugocaillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@tippenein tippenein merged commit c5c2a2a into main Feb 24, 2025
25 checks passed
@tippenein tippenein deleted the chore/fix-define-trait branch February 24, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarinet format with define-trait has unreadable output
2 participants