feat: add new features to hiro-system-kit #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1396 +/- ##
==========================================
- Coverage 40.91% 40.85% -0.07%
==========================================
Files 87 87
Lines 32519 32567 +48
==========================================
Hits 13305 13305
- Misses 19214 19262 +48 ☔ View full report in Codecov by Sentry. |
MicaiahReid
changed the title
lgalabru
previously approved these changes
Mar 27, 2024
hugocaillard
force-pushed
the
feat-hiro-system-kit-level
branch
from
77263f7 to
51f484c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chainhook needs a debug log level that still uses slog_json when built in release mode. This PR adds a new feature to accomplish this.
Additionally, Grafana has set log levels that it uses for parsing logs. Currently the devops team has custom patches to support parsing logs from hiro system kit, because it abbreviates log prefixes in weird ways (
DEBUG=>DEBG,ERROR=>ERRO). This PR also adds a feature,full_log_level_prefix, which just has slog log the full prefix, which will allow devops to remove this custom patches.