Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade clarity-vm - DO NOT MERGE #1325

Closed
wants to merge 4 commits into from

Conversation

hugocaillard
Copy link
Collaborator

Description

Reflect the changes made on the stacks blockchain: stacks-network/stacks-core@12f5d9c

@hugocaillard hugocaillard requested a review from csgui January 23, 2024 10:03
@hugocaillard hugocaillard self-assigned this Jan 23, 2024
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e21ae6e) 41.79% compared to head (075a7c5) 41.80%.

Files Patch % Lines
components/clarity-repl/src/codec/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1325   +/-   ##
========================================
  Coverage    41.79%   41.80%           
========================================
  Files           87       87           
  Lines        32028    32024    -4     
========================================
  Hits         13387    13387           
+ Misses       18641    18637    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hugocaillard hugocaillard force-pushed the chore/upgrade-clarity-vm branch from c37084d to 075a7c5 Compare January 23, 2024 13:57
@hugocaillard hugocaillard marked this pull request as draft January 23, 2024 13:57
@hugocaillard hugocaillard removed the request for review from csgui January 23, 2024 13:57
@hugocaillard hugocaillard changed the title chore: upgrade clarity-vm chore: upgrade clarity-vm DO NOT MERGE Jan 23, 2024
@hugocaillard hugocaillard changed the title chore: upgrade clarity-vm DO NOT MERGE chore: upgrade clarity-vm - DO NOT MERGE Jan 23, 2024
@hstove
Copy link
Contributor

hstove commented Jan 24, 2024

One thing with this branch is that when running clarinet check you get really long output, even when it succeeds. Starting with:

wasm error: [Diagnostic { level: Error, message: "Wasm Runtime Error: Runtime error while interpreting ST3NBRSFKX28FQ2ZJ1MAKX58HKHSDGNV5N7R21XCP.delegate-sig: Wasm(UnableToLoadModule(WebAssembly translation error\n\nCaused by:\n    Invalid input WebAssembly code at offset 5980: type mismatch: expected i64, found i32))", spans: [], suggestion: None }]
result: ExecutionResult { result: Contract(ContractEvaluationResult { result: None, contract: ParsedContract

.... +thousands of more lines

I see this when running in different projects, and I don't think it's related to a specific contract.

@hugocaillard
Copy link
Collaborator Author

@hstove
So this branch include the changes to handle the new wire format of the blockchain, but is probably super late on clarity-wasm.

you get really long output, even when it succeeds

👆 This is still a valid comment.
Clarinet tries to run clarity-wasm and the interpreter in parallel. It will compare the two result but will always the one from the interpreter.
That explains why you can see a big error from clarity-wasm but still a success from the interpreter. In a recent PR (that is not included on this branch), we increase the messaging #1330

@hugocaillard
Copy link
Collaborator Author

Closing in favor of #1372

@hugocaillard hugocaillard deleted the chore/upgrade-clarity-vm branch March 13, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants