Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update bitcoin image to 26.0 #1315

Merged
merged 4 commits into from
Jan 23, 2024
Merged

Conversation

csgui
Copy link
Contributor

@csgui csgui commented Jan 19, 2024

This PR updates Bitcoin image to 26.0.

It also removes the wallet support that seems needless for Clarinet use case.

Fixes: #1305

@csgui csgui requested a review from hugocaillard January 19, 2024 18:21
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e3ce0c2) 41.81% compared to head (766b008) 41.79%.

❗ Current head 766b008 differs from pull request most recent head a2746b2. Consider uploading reports for the commit a2746b2 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1315      +/-   ##
===========================================
- Coverage    41.81%   41.79%   -0.02%     
===========================================
  Files           87       87              
  Lines        32028    32028              
===========================================
- Hits         13391    13387       -4     
- Misses       18637    18641       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@smcclellan smcclellan assigned hugocaillard and csgui and unassigned hugocaillard Jan 22, 2024
@hugocaillard hugocaillard force-pushed the chore/update_bitcoin_image branch from 74415c7 to 766b008 Compare January 23, 2024 09:18
Copy link
Collaborator

@hugocaillard hugocaillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thx @csgui

@hugocaillard hugocaillard enabled auto-merge (squash) January 23, 2024 09:49
@hugocaillard hugocaillard merged commit 39c536a into develop Jan 23, 2024
16 checks passed
@hugocaillard hugocaillard deleted the chore/update_bitcoin_image branch January 23, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Optimize bitcoind 0.25 image
2 participants