Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly determine PoX vs PoB block commitments #499

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

MicaiahReid
Copy link
Contributor

Description

Fixes #496

Checklist

  • All tests pass
  • Tests added in this PR (if applicable)

@lgalabru
Copy link
Contributor

Looking good to me!

Screenshot 2024-02-14 at 11 17 29

Copy link
Contributor

@lgalabru lgalabru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MicaiahReid!

@MicaiahReid MicaiahReid merged commit 82d8e5b into develop Feb 14, 2024
4 of 6 checks passed
@MicaiahReid MicaiahReid deleted the fix-block-commitment branch February 14, 2024 20:58
MicaiahReid added a commit that referenced this pull request Feb 14, 2024
### Description

Fixes #496 

### Checklist

- [X] All tests pass
- [ ] Tests added in this PR (if applicable)
github-actions bot pushed a commit that referenced this pull request Feb 14, 2024
## [1.3.1](v1.3.0...v1.3.1) (2024-02-14)

### Bug Fixes

* add event index to transaction events ([#495](#495)) ([d67d1e4](d67d1e4)), closes [#417](#417) [#387](#387)
* correctly determine PoX vs PoB block commitments ([#499](#499)) ([50dd26f](50dd26f)), closes [#496](#496)
vabanaerytk added a commit to vabanaerytk/chainhook that referenced this pull request Aug 7, 2024
## [1.3.1](hirosystems/chainhook@v1.3.0...v1.3.1) (2024-02-14)

### Bug Fixes

* add event index to transaction events ([#495](hirosystems/chainhook#495)) ([2d2760d](hirosystems/chainhook@2d2760d)), closes [#417](hirosystems/chainhook#417) [#387](hirosystems/chainhook#387)
* correctly determine PoX vs PoB block commitments ([#499](hirosystems/chainhook#499)) ([6816e76](hirosystems/chainhook@6816e76)), closes [#496](hirosystems/chainhook#496)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Stacks block commitments incorrectly assign change outputs as pox transfers
2 participants