-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: buffer decoding of archive file to reduce memory usage #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgalabru
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MicaiahReid!
9189141
to
72dbcec
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Jan 25, 2024
## [1.2.0](v1.1.1...v1.2.0) (2024-01-25) ### Features * add bad request support ([7abe4f6](7abe4f6)) * add inscription transfer destination schema ([526de7a](526de7a)) * add jubilee support for inscription_revealed schemas ([#470](#470)) ([823f430](823f430)) * add Wallet Descriptor Support for Transaction Indexing ([959da29](959da29)) * broadcast ObserverEvent::BitcoinPredicateTriggered on successful requests ([6407e2c](6407e2c)) * broadcast ObserverEvent::BitcoinPredicateTriggered on successful requests ([a6164ea](a6164ea)) * introduce signet mode ([549c775](549c775)) ### Bug Fixes * address review ([687e2ae](687e2ae)) * broken tests ([0e6359e](0e6359e)) * broken tests ([7a0209b](7a0209b)) * buffer decoding of archive file to reduce memory usage ([#450](#450)) ([f1b89f7](f1b89f7)), closes [#401](#401) * build error ([88f597e](88f597e)) * enable default features for hiro-system-kit ([867424a](867424a)) * skip empty chunks when decoding gz ([b4ce82f](b4ce82f)) * **stacks-indexer:** prevent subtract with overflow ([#449](#449)) ([d8d9979](d8d9979)) * update ordhook URLs on typescript client ([9462ae3](9462ae3)) * warnings ([126d049](126d049))
🎉 This PR is included in version 1.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
vabanaerytk
added a commit
to vabanaerytk/chainhook
that referenced
this pull request
Aug 7, 2024
## [1.2.0](hirosystems/chainhook@v1.1.1...v1.2.0) (2024-01-25) ### Features * add bad request support ([18ba26a](hirosystems/chainhook@18ba26a)) * add inscription transfer destination schema ([905f800](hirosystems/chainhook@905f800)) * add jubilee support for inscription_revealed schemas ([#470](hirosystems/chainhook#470)) ([3e57978](hirosystems/chainhook@3e57978)) * add Wallet Descriptor Support for Transaction Indexing ([0e066ab](hirosystems/chainhook@0e066ab)) * broadcast ObserverEvent::BitcoinPredicateTriggered on successful requests ([e8f4ab3](hirosystems/chainhook@e8f4ab3)) * broadcast ObserverEvent::BitcoinPredicateTriggered on successful requests ([7bd87e8](hirosystems/chainhook@7bd87e8)) * introduce signet mode ([18753c1](hirosystems/chainhook@18753c1)) ### Bug Fixes * address review ([510b720](hirosystems/chainhook@510b720)) * broken tests ([e0dcdb7](hirosystems/chainhook@e0dcdb7)) * broken tests ([756c8a6](hirosystems/chainhook@756c8a6)) * buffer decoding of archive file to reduce memory usage ([#450](hirosystems/chainhook#450)) ([472c7be](hirosystems/chainhook@472c7be)), closes [#401](hirosystems/chainhook#401) * build error ([f790761](hirosystems/chainhook@f790761)) * enable default features for hiro-system-kit ([5284082](hirosystems/chainhook@5284082)) * skip empty chunks when decoding gz ([9faacfe](hirosystems/chainhook@9faacfe)) * **stacks-indexer:** prevent subtract with overflow ([#449](hirosystems/chainhook#449)) ([767cd8e](hirosystems/chainhook@767cd8e)) * update ordhook URLs on typescript client ([8ce3c3d](hirosystems/chainhook@8ce3c3d)) * warnings ([fbd7040](hirosystems/chainhook@fbd7040))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #401
Previously, memory usage peaked at 32 GB. Now, I didn't see it go above 8 MB