some cleanup

hirosystems · Mar 12, 2024 · 2ede947 · 2ede947
1 parent 5aa6297
commit 2ede947
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/components/chainhook-cli/src/service/mod.rs b/components/chainhook-cli/src/service/mod.rs
@@ -423,7 +423,7 @@ impl Service {
                         Err(e) => {
                             error!(
                                 self.ctx.expect_logger(),
-                                "unable to store stacks block: {}",
+                                "unable to open stacks db: {}",
                                 e.to_string()
                             );
                             continue;

diff --git a/components/chainhook-cli/src/service/runloops.rs b/components/chainhook-cli/src/service/runloops.rs
@@ -43,9 +43,12 @@ pub fn start_stacks_scan_runloop(
                 {
                     Ok(db_conn) => db_conn,
                     Err(e) => {
+                        // todo: if we repeatedly can't connect to the database, we should restart the
+                        // service to get to a healthy state. I don't know if this has been an issue, though
+                        // so we can monitor and possibly remove this todo
                         error!(
                             moved_ctx.expect_logger(),
-                            "unable to store stacks block: {}",
+                            "unable to open stacks db: {}",
                             e.to_string()
                         );
                         unimplemented!()
@@ -108,8 +111,7 @@ pub fn start_stacks_scan_runloop(
             }
         });
     }
-    let res = stacks_scan_pool.join();
-    res
+    let _ = stacks_scan_pool.join();
 }
 
 pub fn start_bitcoin_scan_runloop(