Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(jasmine-given): support for jasmine-core 4 #10

Merged
merged 2 commits into from
Mar 11, 2022
Merged

chore(jasmine-given): support for jasmine-core 4 #10

merged 2 commits into from
Mar 11, 2022

Conversation

WynieCronje
Copy link

Updated project dependencies to work with latest jasmine

fix #9

chore(jasmine-given): support for jasmine-core 4
c3632fd 
Updated project dependencies to work with latest jasmine

hirezio#9
@similar-code-searcher
Copy link

Similar files are

2 similar comments
@similar-code-searcher
Copy link

Similar files are

@similar-code-searcher
Copy link

Similar files are

WynieCronje
WynieCronje commented Mar 10, 2022
View reviewed changes
packages/jasmine-given/spec/jasmine-given.spec.ts
@@ -164,7 +164,7 @@ describe('Jasmine Given', () => {
});

describe('Then() should pass an empty string to it() given no label', () => {
beforeEach(() => {
it('should not add the label', () => {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed below error:

image

@shairez
Copy link
Member

shairez commented Mar 11, 2022

Thanks @WynieCronje !

did you run yarn test from the root of the project?

@codecov
Copy link

codecov bot commented Mar 11, 2022 •
edited
Loading

Codecov Report

Merging #10 (51ce47c) into master (1b8d0a9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #10   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           52        52           
  Branches         9         9           
=========================================
  Hits            52        52

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b8d0a9...51ce47c. Read the comment docs.

@WynieCronje
Copy link
Author

WynieCronje commented Mar 11, 2022 •
edited
Loading

@shairez I tried running yarn test in root had buggy behaviour. (I'm using project level yarn)

So I ran yarn test:jasmine and yarn test:jest separately.

The action seemed to fail on Authentication level (assuming to npm)

image

@shairez
Copy link
Member

shairez commented Mar 11, 2022

Let me fix that real quick

@shairez
Copy link
Member

shairez commented Mar 11, 2022

@WynieCronje
BTW, what do you mean by "buggy behavior" on yarn test ?

@WynieCronje
Copy link
Author

WynieCronje commented Mar 11, 2022 •
edited
Loading

@WynieCronje
BTW, what do you mean by "buggy behavior" on yarn test ?

No tests ran (at least no test result’s were shown). And some updates were happening in the terminal when saving files

@shairez shairez closed this Mar 11, 2022
@shairez shairez reopened this Mar 11, 2022
@shairez shairez merged commit a509862 into hirezio:master Mar 11, 2022
@shairez
Copy link
Member

shairez commented Mar 11, 2022

@all-contributors please add @WynieCronje for code, tests, maintenance

@allcontributors allcontributors bot mentioned this pull request Mar 11, 2022
Merged
@allcontributors
Copy link
Contributor

@shairez

I've put up a pull request to add @WynieCronje! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make jasmine-given compatible with jasmine-core 4
2 participants
@WynieCronje @shairez