hirezio · Jan 10, 2022 · Mar 10, 2022 · Mar 11, 2022 · Mar 11, 2022 · Mar 11, 2022
diff --git a/.all-contributorsrc b/.all-contributorsrc
@@ -0,0 +1,43 @@
+{
+  "files": [
+    "README.md"
+  ],
+  "imageSize": 100,
+  "commit": true,
+  "commitConvention": "angular",
+  "contributors": [
+    {
+      "login": "shairez",
+      "name": "Shai Reznik",
+      "avatar_url": "https://avatars1.githubusercontent.com/u/1430726?v=4",
+      "profile": "https://www.hirez.io/?utm_medium=Open_Source&utm_source=Github&utm_campaign=Lead_Generation&utm_content=given--all-contributors-profile-link",
+      "contributions": [
+        "code",
+        "doc",
+        "ideas",
+        "infra",
+        "maintenance",
+        "mentoring",
+        "review",
+        "test"
+      ]
+    },
+    {
+      "login": "WynieCronje",
+      "name": "WynieCronje",
+      "avatar_url": "https://avatars.githubusercontent.com/u/4537265?v=4",
+      "profile": "https://github.com/WynieCronje",
+      "contributions": [
+        "code",
+        "test",
+        "maintenance"
+      ]
+    }
+  ],
+  "contributorsPerLine": 7,
+  "projectName": "given",
+  "projectOwner": "hirezio",
+  "repoType": "github",
+  "repoHost": "https://github.com",
+  "skipCi": true
+}
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -1,13 +1,59 @@
-name: Build and optionally publish
+name: Build
 on:
   push:
     branches:
       - master
       - staging
   pull_request:
 jobs:
+  build:
+    name: Build and test on node ${{ matrix.node }}
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        node: ['14', '16']
+    env:
+      GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
+      NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
+    steps:
+      - name: Checkout Repo
+        uses: actions/checkout@v2
+        with:
+          fetch-depth: '0'
+      - name: Setup Node
+        uses: actions/setup-node@v2-beta
+        with:
+          node-version: ${{ matrix.node }}
+          registry-url: 'https://registry.npmjs.org'
+      - name: Get yarn cache dir
+        id: yarn-cache-dir-path
+        run: echo "::set-output name=dir::$(yarn cache dir)"
+
+      - name: Cache Dependencies
+        uses: actions/cache@v2
+        id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`)
+        with:
+          path: |
+            ${{ steps.yarn-cache-dir-path.outputs.dir }}
+            node_modules
+            */*/node_modules
+          key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
+          restore-keys: |
+            ${{ runner.os }}-yarn-
+
+      - name: Install dependencies
+        run: yarn install --frozen-lockfile
+
+      - name: Build
+        run: yarn build
+
+      - name: Run Lint and Tests
+        run: yarn test:full
   release:
-    name: Test, Build and Release
+    name: Release
+    if: github.event_name == 'push' && github.ref == 'refs/heads/master'
+    needs: build
     runs-on: ubuntu-latest
     env:
       GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
@@ -21,7 +67,7 @@ jobs:
       - name: Setup Node
         uses: actions/setup-node@v2-beta
         with:
-          node-version: '12'
+          node-version: '16'
           registry-url: 'https://registry.npmjs.org'
           scope: '@hirez_io'
 
@@ -42,7 +88,7 @@ jobs:
             ${{ runner.os }}-yarn-
 
       - name: Install dependencies
-        run: yarn install
+        run: yarn install --frozen-lockfile
 
       - name: Build
         run: yarn build

diff --git a/README.md b/README.md
@@ -1,5 +1,11 @@
 # (jasmine | jest)-given Monorepo
 
+<!-- ALL-CONTRIBUTORS-BADGE:START - Do not remove or modify this section -->
+
+[![All Contributors](https://img.shields.io/badge/all_contributors-2-orange.svg?style=flat-square)](#contributors-)
+
+<!-- ALL-CONTRIBUTORS-BADGE:END -->
+
 ## Packages
 
 This repository contains the HiRez.io's versions of:
@@ -42,10 +48,6 @@ Thanks 🙏
 
 Be kind to each other and please read our [code of conduct](CODE_OF_CONDUCT.md).
 
-## License
-
-MIT
-
 ## Want to learn more?
 
 <div align="center">
@@ -56,3 +58,28 @@ MIT
     />
   </a>
 </div>
+
+## Contributors ✨
+
+Thanks goes to these wonderful people ([emoji key](https://allcontributors.org/docs/en/emoji-key)):
+
+<!-- ALL-CONTRIBUTORS-LIST:START - Do not remove or modify this section -->
+<!-- prettier-ignore-start -->
+<!-- markdownlint-disable -->
+<table>
+  <tr>
+    <td align="center"><a href="https://www.hirez.io/?utm_medium=Open_Source&utm_source=Github&utm_campaign=Lead_Generation&utm_content=given--all-contributors-profile-link"><img src="https://avatars1.githubusercontent.com/u/1430726?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Shai Reznik</b></sub></a><br /><a href="https://github.com/hirezio/given/commits?author=shairez" title="Code">💻</a> <a href="https://github.com/hirezio/given/commits?author=shairez" title="Documentation">📖</a> <a href="#ideas-shairez" title="Ideas, Planning, & Feedback">🤔</a> <a href="#infra-shairez" title="Infrastructure (Hosting, Build-Tools, etc)">🚇</a> <a href="#maintenance-shairez" title="Maintenance">🚧</a> <a href="#mentoring-shairez" title="Mentoring">🧑‍🏫</a> <a href="https://github.com/hirezio/given/pulls?q=is%3Apr+reviewed-by%3Ashairez" title="Reviewed Pull Requests">👀</a> <a href="https://github.com/hirezio/given/commits?author=shairez" title="Tests">⚠️</a></td>
+    <td align="center"><a href="https://github.com/WynieCronje"><img src="https://avatars.githubusercontent.com/u/4537265?v=4?s=100" width="100px;" alt=""/><br /><sub><b>WynieCronje</b></sub></a><br /><a href="https://github.com/hirezio/given/commits?author=WynieCronje" title="Code">💻</a> <a href="https://github.com/hirezio/given/commits?author=WynieCronje" title="Tests">⚠️</a> <a href="#maintenance-WynieCronje" title="Maintenance">🚧</a></td>
+  </tr>
+</table>
+
+<!-- markdownlint-restore -->
+<!-- prettier-ignore-end -->
+
+<!-- ALL-CONTRIBUTORS-LIST:END -->
+
+This project follows the [all-contributors](https://github.com/all-contributors/all-contributors) specification. Contributions of any kind welcome!
+
+## License
+
+MIT
diff --git a/packages/jasmine-given/.all-contributorsrc b/packages/jasmine-given/.all-contributorsrc
@@ -0,0 +1,44 @@
+{
+  "files": [
+    "README.md",
+    "../../README.md"
+  ],
+  "imageSize": 100,
+  "commit": true,
+  "commitConvention": "angular",
+  "contributors": [
+    {
+      "login": "shairez",
+      "name": "Shai Reznik",
+      "avatar_url": "https://avatars1.githubusercontent.com/u/1430726?v=4",
+      "profile": "https://www.hirez.io/?utm_medium=Open_Source&utm_source=Github&utm_campaign=Lead_Generation&utm_content=given--all-contributors-profile-link",
+      "contributions": [
+        "code",
+        "doc",
+        "ideas",
+        "infra",
+        "maintenance",
+        "mentoring",
+        "review",
+        "test"
+      ]
+    },
+    {
+      "login": "WynieCronje",
+      "name": "WynieCronje",
+      "avatar_url": "https://avatars.githubusercontent.com/u/4537265?v=4",
+      "profile": "https://github.com/WynieCronje",
+      "contributions": [
+        "code",
+        "test",
+        "maintenance"
+      ]
+    }
+  ],
+  "contributorsPerLine": 7,
+  "projectName": "given",
+  "projectOwner": "hirezio",
+  "repoType": "github",
+  "repoHost": "https://github.com",
+  "skipCi": true
+}
diff --git a/packages/jasmine-given/CHANGELOG.md b/packages/jasmine-given/CHANGELOG.md
@@ -3,6 +3,22 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [1.0.7](https://github.com/hirezio/given/compare/@hirez_io/jasmine-given@1.0.6...@hirez_io/jasmine-given@1.0.7) (2022-03-13)
+
+**Note:** Version bump only for package @hirez_io/jasmine-given
+
+
+
+
+
+## [1.0.6](https://github.com/hirezio/given/compare/@hirez_io/jasmine-given@1.0.5...@hirez_io/jasmine-given@1.0.6) (2022-03-11)
+
+**Note:** Version bump only for package @hirez_io/jasmine-given
+
+
+
+
+
 ## [1.0.5](https://github.com/hirezio/given/compare/@hirez_io/jasmine-given@1.0.4...@hirez_io/jasmine-given@1.0.5) (2021-01-22)
 
 **Note:** Version bump only for package @hirez_io/jasmine-given

diff --git a/packages/jasmine-given/README.md b/packages/jasmine-given/README.md
@@ -8,7 +8,10 @@ A jasmine addon that helps you clean up your microtests by breaking them into a
 ![Build and optionally publish](https://github.com/hirezio/given/workflows/Build%20and%20optionally%20publish/badge.svg)
 [![lerna](https://img.shields.io/badge/maintained%20with-lerna-cc00ff.svg)](https://lerna.js.org/)
 [![Code of Conduct](https://img.shields.io/badge/code%20of-conduct-ff69b4.svg?style=flat-square)](../../CODE_OF_CONDUCT.md)
-[![License: MIT](https://img.shields.io/badge/License-MIT-green.svg)](https://opensource.org/licenses/MIT)
+[![License: MIT](https://img.shields.io/badge/License-MIT-green.svg)](https://opensource.org/licenses/MIT) <!-- ALL-CONTRIBUTORS-BADGE:START - Do not remove or modify this section -->
+[![All Contributors](https://img.shields.io/badge/all_contributors-2-green.svg?style=flat-square)](#contributors-)
+
+<!-- ALL-CONTRIBUTORS-BADGE:END -->
 
 <div align="center">
   <a href="https://learn.hirez.io/?utm_source=github&utm_medium=link&utm_campaign=jasmine-given">
@@ -269,6 +272,27 @@ Thanks 🙏
 
 Be kind to each other and please read our [code of conduct](../../CODE_OF_CONDUCT.md).
 
+## Contributors ✨
+
+Thanks goes to these wonderful people ([emoji key](https://allcontributors.org/docs/en/emoji-key)):
+
+<!-- ALL-CONTRIBUTORS-LIST:START - Do not remove or modify this section -->
+<!-- prettier-ignore-start -->
+<!-- markdownlint-disable -->
+<table>
+  <tr>
+    <td align="center"><a href="https://www.hirez.io/?utm_medium=Open_Source&utm_source=Github&utm_campaign=Lead_Generation&utm_content=jasmine-given--all-contributors-profile-link"><img src="https://avatars1.githubusercontent.com/u/1430726?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Shai Reznik</b></sub></a><br /><a href="https://github.com/hirezio/given/commits?author=shairez" title="Code">💻</a> <a href="https://github.com/hirezio/given/commits?author=shairez" title="Documentation">📖</a> <a href="#ideas-shairez" title="Ideas, Planning, & Feedback">🤔</a> <a href="#infra-shairez" title="Infrastructure (Hosting, Build-Tools, etc)">🚇</a> <a href="#maintenance-shairez" title="Maintenance">🚧</a> <a href="#mentoring-shairez" title="Mentoring">🧑‍🏫</a> <a href="https://github.com/hirezio/given/pulls?q=is%3Apr+reviewed-by%3Ashairez" title="Reviewed Pull Requests">👀</a> <a href="https://github.com/hirezio/given/commits?author=shairez" title="Tests">⚠️</a></td>
+    <td align="center"><a href="https://github.com/WynieCronje"><img src="https://avatars.githubusercontent.com/u/4537265?v=4?s=100" width="100px;" alt=""/><br /><sub><b>WynieCronje</b></sub></a><br /><a href="https://github.com/hirezio/given/commits?author=WynieCronje" title="Code">💻</a> <a href="https://github.com/hirezio/given/commits?author=WynieCronje" title="Tests">⚠️</a> <a href="#maintenance-WynieCronje" title="Maintenance">🚧</a></td>
+  </tr>
+</table>
+
+<!-- markdownlint-restore -->
+<!-- prettier-ignore-end -->
+
+<!-- ALL-CONTRIBUTORS-LIST:END -->
+
+This project follows the [all-contributors](https://github.com/all-contributors/all-contributors) specification. Contributions of any kind welcome!
+
 ## License
 
 MIT
diff --git a/packages/jasmine-given/package.json b/packages/jasmine-given/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@hirez_io/jasmine-given",
-  "version": "1.0.5",
+  "version": "1.0.7",
   "publishConfig": {
     "access": "public",
     "registry": "https://registry.npmjs.com"
@@ -41,15 +41,15 @@
     "test": "echo \n*** Run tests from the root folder\n"
   },
   "dependencies": {
-    "@hirez_io/karma-jasmine-given": "^1.1.0"
+    "@hirez_io/karma-jasmine-given": "^1.1.1"
   },
   "peerDependencies": {
-    "jasmine-core": "< 4.x"
+    "jasmine-core": "< 5.x"
   },
   "devDependencies": {
     "@types/jasmine": "3.5.11",
     "cpy-cli": "^3.1.1",
-    "jasmine": "3.5.0",
+    "jasmine": "4.0.2",
     "microbundle": "^0.12.3",
     "nodemon": "2.0.4",
     "nyc": "15.1.0",

diff --git a/packages/jasmine-given/spec/jasmine-given.spec.ts b/packages/jasmine-given/spec/jasmine-given.spec.ts
@@ -164,7 +164,7 @@ describe('Jasmine Given', () => {
   });
 
   describe('Then() should pass an empty string to it() given no label', () => {
-    beforeEach(() => {
+    it('should not add the label', () => {
       spyOn(root, 'it');
       Then(() => {});
       const actualLabel = (it as jasmine.Spy).calls.first().args[0];

diff --git a/packages/jest-given/.all-contributorsrc b/packages/jest-given/.all-contributorsrc
@@ -0,0 +1,33 @@
+{
+  "files": [
+    "README.md",
+    "../../README.md"
+  ],
+  "imageSize": 100,
+  "commit": true,
+  "commitConvention": "angular",
+  "contributors": [
+    {
+      "login": "shairez",
+      "name": "Shai Reznik",
+      "avatar_url": "https://avatars1.githubusercontent.com/u/1430726?v=4",
+      "profile": "https://www.hirez.io/?utm_medium=Open_Source&utm_source=Github&utm_campaign=Lead_Generation&utm_content=jest-given--all-contributors-profile-link",
+      "contributions": [
+        "code",
+        "doc",
+        "ideas",
+        "infra",
+        "maintenance",
+        "mentoring",
+        "review",
+        "test"
+      ]
+    }
+  ],
+  "contributorsPerLine": 7,
+  "projectName": "given",
+  "projectOwner": "hirezio",
+  "repoType": "github",
+  "repoHost": "https://github.com",
+  "skipCi": true
+}
diff --git a/packages/jest-given/CHANGELOG.md b/packages/jest-given/CHANGELOG.md
@@ -3,6 +3,14 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [1.0.4](https://github.com/hirezio/given/compare/@hirez_io/jest-given@1.0.3...@hirez_io/jest-given@1.0.4) (2022-03-13)
+
+**Note:** Version bump only for package @hirez_io/jest-given
+
+
+
+
+
 ## [1.0.3](https://github.com/hirezio/given/compare/@hirez_io/jest-given@1.0.2...@hirez_io/jest-given@1.0.3) (2020-08-25)
 
 **Note:** Version bump only for package @hirez_io/jest-given