This repository has been archived by the owner on Feb 23, 2025. It is now read-only.
refactor: render full document html via React #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just cherry-picked single commit since conflict was too much...
Hmm, error boundary is not looking good since it also re-renders full document on client.
2024-01-05.15-30-41.webm
To fix this, probably we need to put theme system into react world, which I see as unnecessary architectural burden. So, not rendering full document by React definitely has advantage with these little things.
Or this "boundary route" idea might be better than that:
Probably it's possible to inject such "boundary route" via custom route config?
Or just go for React 18.3 with robust html/head/body CSR?
Well, actually this "robust"-ness cannot magically merge
<html class=... />since that would change react props semantics...