Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not widen body type on optional prop #639

Merged
merged 1 commit into from
May 29, 2024

Conversation

mrlubos
Copy link
Member

@mrlubos mrlubos commented May 29, 2024

Closes #625

Copy link

stackblitz bot commented May 29, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

vercel bot commented May 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2024 10:44am

Copy link

changeset-bot bot commented May 29, 2024

🦋 Changeset detected

Latest commit: 820002f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@hey-api/client-fetch Patch
@example/openapi-ts-fetch Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mrlubos mrlubos marked this pull request as ready for review May 29, 2024 09:45
Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.67%. Comparing base (3e72297) to head (820002f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #639   +/-   ##
=======================================
  Coverage   75.67%   75.67%           
=======================================
  Files          74       74           
  Lines        7400     7400           
  Branches      692      692           
=======================================
  Hits         5600     5600           
  Misses       1797     1797           
  Partials        3        3           
Flag Coverage Δ
unittests 75.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrlubos mrlubos merged commit cdab2d5 into main May 29, 2024
16 checks passed
@mrlubos mrlubos deleted the fix/fetch-client-body-types branch May 29, 2024 10:49
@github-actions github-actions bot mentioned this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type of body is widened by default without any provided known properties
1 participant