Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deduplicate exported data and response types #538

Merged
merged 2 commits into from
May 6, 2024

Conversation

mrlubos
Copy link
Member

@mrlubos mrlubos commented May 6, 2024

Closes #534

@mrlubos mrlubos requested a review from jordanshatford May 6, 2024 04:58
Copy link

stackblitz bot commented May 6, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented May 6, 2024

🦋 Changeset detected

Latest commit: c9cf5da

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented May 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2024 5:43am

Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 58.55670% with 201 lines in your changes are missing coverage. Please review.

Project coverage is 75.98%. Comparing base (afa3bd6) to head (c9cf5da).

Files Patch % Lines
packages/openapi-ts/src/utils/write/types.ts 27.85% 101 Missing ⚠️
packages/openapi-ts/src/utils/write/services.ts 17.20% 77 Missing ⚠️
packages/openapi-ts/src/utils/write/type.ts 81.35% 11 Missing ⚠️
.../v2/parser/getRequiredPropertiesFromComposition.ts 0.00% 5 Missing ⚠️
packages/openapi-ts/src/utils/write/schemas.ts 50.00% 4 Missing ⚠️
...-ts/src/openApi/v2/parser/getOperationParameter.ts 93.33% 1 Missing ⚠️
...kages/openapi-ts/src/openApi/v3/parser/getModel.ts 95.83% 1 Missing ⚠️
...-ts/src/openApi/v3/parser/getOperationParameter.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #538      +/-   ##
==========================================
- Coverage   76.54%   75.98%   -0.56%     
==========================================
  Files          75       75              
  Lines        6497     6743     +246     
  Branches      632      642      +10     
==========================================
+ Hits         4973     5124     +151     
- Misses       1521     1616      +95     
  Partials        3        3              
Flag Coverage Δ
unittests 75.98% <58.55%> (-0.56%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -784,7 +784,7 @@ export const $CompositionWithNestedAnyOfAndNull = {
items: {
anyOf: [
{
'$ref': '#/components/schemas/Enum1'
'$ref': '#/components/schemas/3e-num_1%D0%9F%D0%B5%D1%80%D0%B8%D0%BE%D0%B4'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something strange here

@mrlubos mrlubos force-pushed the fix/dedup-exported-types branch from 1ffbbb4 to 45b4915 Compare May 6, 2024 05:42
@mrlubos mrlubos marked this pull request as ready for review May 6, 2024 05:43
@mrlubos mrlubos merged commit e73df34 into main May 6, 2024
14 of 16 checks passed
@mrlubos mrlubos deleted the fix/dedup-exported-types branch May 6, 2024 05:48
@github-actions github-actions bot mentioned this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conflict Response type
2 participants