Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not destructure data when using use options #450

Merged
merged 1 commit into from
Apr 20, 2024

Conversation

jordanshatford
Copy link
Collaborator

This will prevent issues like const { data } = data

@jordanshatford jordanshatford requested a review from mrlubos April 19, 2024 23:46
Copy link

codesandbox bot commented Apr 19, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

changeset-bot bot commented Apr 19, 2024

🦋 Changeset detected

Latest commit: 0c1bc3e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 19, 2024 11:48pm

Copy link
Member

@mrlubos mrlubos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely!

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 79.80%. Comparing base (2357fd2) to head (0c1bc3e).

Files Patch % Lines
packages/openapi-ts/src/utils/write/services.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #450      +/-   ##
==========================================
+ Coverage   79.55%   79.80%   +0.24%     
==========================================
  Files          75       75              
  Lines        6007     5986      -21     
  Branches      608      608              
==========================================
- Hits         4779     4777       -2     
+ Misses       1227     1208      -19     
  Partials        1        1              
Flag Coverage Δ
unittests 79.80% <0.00%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jordanshatford jordanshatford merged commit 3b53f5e into main Apr 20, 2024
15 of 16 checks passed
@jordanshatford jordanshatford deleted the fix/do-no-destructure branch April 20, 2024 00:57
@github-actions github-actions bot mentioned this pull request Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants