Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only remove core directory when export core is true #449

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

jordanshatford
Copy link
Collaborator

closes: #445

@jordanshatford jordanshatford requested a review from mrlubos April 19, 2024 23:13
Copy link

codesandbox bot commented Apr 19, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

changeset-bot bot commented Apr 19, 2024

🦋 Changeset detected

Latest commit: 1545789

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 19, 2024 11:13pm

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.55%. Comparing base (840d9df) to head (1545789).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #449      +/-   ##
==========================================
- Coverage   79.58%   79.55%   -0.03%     
==========================================
  Files          75       75              
  Lines        6015     6007       -8     
  Branches      608      608              
==========================================
- Hits         4787     4779       -8     
  Misses       1227     1227              
  Partials        1        1              
Flag Coverage Δ
unittests 79.55% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jordanshatford jordanshatford merged commit 2357fd2 into main Apr 19, 2024
16 checks passed
@jordanshatford jordanshatford deleted the fix/only-remove-core-files-when-writing branch April 19, 2024 23:23
@github-actions github-actions bot mentioned this pull request Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

exportCore=false deletes contents of ./core in target directory
2 participants