Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: template bugs #431

Merged
merged 2 commits into from
Apr 19, 2024
Merged

fix: template bugs #431

merged 2 commits into from
Apr 19, 2024

Conversation

jordanshatford
Copy link
Collaborator

closes: #419
closes: #406

@jordanshatford jordanshatford requested a review from mrlubos April 19, 2024 00:05
Copy link

codesandbox bot commented Apr 19, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

changeset-bot bot commented Apr 19, 2024

🦋 Changeset detected

Latest commit: 0b75192

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 19, 2024 0:18am

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 80.35%. Comparing base (0e1776b) to head (0b75192).

Files Patch % Lines
packages/openapi-ts/src/compiler/utils.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #431   +/-   ##
=======================================
  Coverage   80.35%   80.35%           
=======================================
  Files          75       75           
  Lines        5950     5950           
  Branches      606      606           
=======================================
  Hits         4781     4781           
  Misses       1168     1168           
  Partials        1        1           
Flag Coverage Δ
unittests 80.35% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +849 to +870
* [
* {
* "resourceType": "Asset",
* "identifier": {
* "name": "${1}",
* "domain": {
* "name": "${2}",
* "community": {
* "name": "Some Community"
* }
* }
* },
* "attributes" : {
* "00000000-0000-0000-0000-000000003115" : [ {
* "value" : "${3}"
* } ],
* "00000000-0000-0000-0000-000000000222" : [ {
* "value" : "${4}"
* } ]
* }
* }
* ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we losing indentation in these?

@mrlubos mrlubos merged commit 70222a2 into main Apr 19, 2024
15 of 16 checks passed
@mrlubos mrlubos deleted the fix/template-bugs branch April 19, 2024 00:39
@github-actions github-actions bot mentioned this pull request Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error generating services.gen.ts Cannot find name 'x'.ts(2304) in generated code
2 participants